Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

chore: example rewrite #381

Merged
merged 2 commits into from
Aug 9, 2023
Merged

chore: example rewrite #381

merged 2 commits into from
Aug 9, 2023

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Aug 8, 2023

This is a complete rewrite of the example with minimal code duplication.

I also removed everything inside the example that manipulated the real sizes or colors of the elements being shown.
(for example height/width of textfields and the iconbutton for the dark/light)

Also ordered the widgets better by "type".

Bildschirmaufnahme.2023-08-08.um.23.35.30.mov

Fixes #380

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement !
I only have a little note.

example/lib/src/controls/progres.dart Outdated Show resolved Hide resolved
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Feichtmeier Feichtmeier merged commit 09c17b1 into main Aug 9, 2023
7 checks passed
@Feichtmeier Feichtmeier deleted the Feichtmeier/issue380 branch August 9, 2023 17:53
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example rewrite
2 participants