Skip to content

broker.conf: Improve the force_provider_authentication comment #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

adombeck
Copy link
Contributor

@adombeck adombeck commented Apr 7, 2025

Inspired by the wording in the user documentation
(ubuntu/authd#870).

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.36%. Comparing base (25f84e8) to head (1adf270).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files          22       22           
  Lines        1034     1034           
=======================================
  Hits          831      831           
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adombeck adombeck force-pushed the improve-comment-in-config-file branch 2 times, most recently from 11a2468 to 1898f90 Compare April 8, 2025 12:09
Based on the wording in the user documentation
(see ubuntu/authd#870).
@adombeck adombeck force-pushed the improve-comment-in-config-file branch from 1898f90 to 1adf270 Compare April 10, 2025 07:25
@adombeck adombeck marked this pull request as ready for review April 10, 2025 07:25
@adombeck adombeck requested a review from a team as a code owner April 10, 2025 07:25
Copy link

@edibotopic edibotopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me.

Thanks for updating.

@adombeck adombeck merged commit 1355d46 into main Apr 10, 2025
3 of 4 checks passed
@adombeck adombeck deleted the improve-comment-in-config-file branch April 10, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants