-
Notifications
You must be signed in to change notification settings - Fork 26
docs: document enabling forced authentication in config guide #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b60a5c3
to
d5769cc
Compare
3v1n0
reviewed
Apr 3, 2025
d5769cc
to
e48505a
Compare
Thanks @3v1n0 and @adombeck -- I addressed your comments in e48505a . Two things to consider for the future:
|
adombeck
reviewed
Apr 7, 2025
adombeck
added a commit
to ubuntu/authd-oidc-brokers
that referenced
this pull request
Apr 7, 2025
Inspired by the wording in the user documentation (ubuntu/authd#870).
adombeck
added a commit
to ubuntu/authd-oidc-brokers
that referenced
this pull request
Apr 7, 2025
Inspired by the wording in the user documentation (ubuntu/authd#870).
e48505a
to
3d55345
Compare
adombeck
approved these changes
Apr 8, 2025
adombeck
added a commit
to ubuntu/authd-oidc-brokers
that referenced
this pull request
Apr 8, 2025
Based on the wording in the user documentation (see ubuntu/authd#870).
- includes description of forced auth config - description is consolidated from config comments - want to avoid detailed explanations in how-to, ideally (token refresh aspect could be described in a later authentication mechanism explanation)
Makes more clear that when force_provider_authentication is true: - user needs to be online and provider needs to be reachable - the authentication is therefore ONLINE with the REMOTE provider Further explanation is beyond the scope a how-to but the how-to can link to a supplmentary explanation at a later date.
referring to a remote identity provider introduces needless ambiguity
3d55345
to
a4b0970
Compare
adombeck
added a commit
to ubuntu/authd-oidc-brokers
that referenced
this pull request
Apr 10, 2025
Based on the wording in the user documentation (see ubuntu/authd#870).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDENG-6585