Add tags to ignore static check on helper files #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For someone who doesn't know much about TiCS (like me :)), there's a gap in the reasoning here. I assume that:
If that's correct, could you please add a sentence in the commit message explaining this? |
We have a lot of helper files to help us test our project and those are protected to not be built with "go build" to avoid having those in the release binary. Since they are not part of what we use in production, we don't want them listed in the static analysis checks as it would give us wrong metrics on the results. To avoid having to update tics configuration every time we rename those files or add new ones, let's tag them and filter those out in the analysis.
denisonbarbosa
force-pushed
the
add-tags-to-disable-tics-analysis
branch
from
f082b7a to
ddbd12a
Compare
adombeck
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of helper files to help us test our project and those are protected to not be built with "go build" to avoid having those in the release binary. To avoid having to update tics configuration every time we rename those files or add new ones, let's tag them and filter those out in the analysis.