Update GOCART to v2.4.3 #2819

bbakernoaa · 2025-07-21T17:43:18Z

Commit Queue Requirements:

Fill out all sections of this template.
All sub component pull requests have been reviewed by their code managers.
Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
Commit 'test_changes.list' from previous step

Description:

This pull request updates the GOCART model to v2.4.3 to address a numerical instability issue. It also introduces significant updates to the GOCART aerosol model configuration files, focusing on dust parameterization, wet removal schemes, and file references for input data to be inline with GCAFSv1. The changes aim to improve accuracy and flexibility in the model's handling of aerosol processes. Below is a summary of the most important changes grouped by theme:

Updates to Dust Parameterization:

Updated input file references for dust parameters (DU_CLAY, DU_SAND, DU_UTHRES, DU_RDRAG, DU_GVF, and DU_LAI) to use newer datasets from the ExtData/nexus/FENGSHA directory for improved data quality.

Wet Removal Scheme Enhancements:

Introduced a new wet_removal_scheme option (ufs) across multiple configuration files (CA2G_instance_CA.bc.rc, CA2G_instance_CA.oc.rc, DU2G_instance_DU.rc, and SS2G_instance_SS.rc). Added rainout efficiency parameters (fwet_ice, fwet_snow, fwet_rain) for better handling of aerosol scavenging. [1] [2] [3] [4]

File and Parameter Reassignments:

Swapped resource file references between tests/parm/gocart/CA2G_instance_CA.oc.rc and DU2G_instance_DU.rc, effectively reassigning dust and organic carbon parameters to their correct configuration files. [1] [2]

These changes collectively enhance the GOCART model's capability to simulate aerosol processes with updated datasets, improved parameterization, and expanded options for wet removal mechanisms.

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - updated to GOCART v2.4.3
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics -

Priority:

Critical Bugfix: Instability in settling velocity causing undo growth in seasalt in highly convective regions.

Git Tracking

UFSWM:

Closes Update GOCART RT inputs #2817
Closes GOCART Settling issue #2809
Closes Feature/settling fix GEOS-ESM/GOCART#345

Sub component Pull Requests:

AQM:
CDEPS:
CICE:
CMEPS:
CMakeModules:
FV3:
- ccpp-physics:
- atmos_cubed_sphere:
GOCART: Feature/settling fix GEOS-ESM/GOCART#345
HYCOM:
MOM6:
NOAHMP:
WW3:
fire_behavior:
stochastic_physics:
None

UFSWM Blocking Dependencies:

Blocked by #
None

Documentation:

No documentation update is required for this PR: change of module hash.

Changes

Regression Test Changes (Please commit test_changes.list):

PR Updates/Changes Baselines.

Input data Changes:

New input data.
Updated input data.

As #2817 states we should sync the inputs to the same as needed for GCAFSv1. At this point only the dust inputs have changed for the RT.

Library Changes/Upgrades:

Testing Log:

…odeling to be inline with GCAFSv1

…ate related settings

…ng, including wet removal scheme adjustments

dpsarmie · 2025-07-21T18:59:01Z

@jkbk2004, this is one of the other priority PRs that we discussed for GW/GFS, just putting it on your radar.

JessicaMeixner-NOAA · 2025-07-22T12:45:17Z

I have confirmed this solves the g-w PR issue, see: NOAA-EMC/global-workflow#3840 (comment) for test results. Thanks @bbakernoaa !!!!

…mes and adjust file paths for consistency

bbakernoaa · 2025-07-22T17:30:58Z

@dpsarmie this is making its way steadily though the RTs on GAEA c6 for me. What should I do next

dpsarmie · 2025-07-22T19:49:35Z

@dpsarmie this is making its way steadily though the RTs on GAEA c6 for me. What should I do next

Great! Once the RTs are completed, just upload the test_changes.list file to the PR. Jong and EPIC will ask you to update the branch once this is ready to be tested/merged. This is scheduled to be the next PR after #2814 is merged. There's a chance that this PR is combined with another PR but we can work through that if that happens.

bbakernoaa · 2025-07-24T14:43:13Z

@dpsarmie I uploaded the test_changes.list

One note that I did have to add the path to the new input files in the AERO_ExtData.rc files for Ursa. Other machines will need this to be synced as well for the RT inputs.

directory on URSA: /scratch4/NCEPDEV/naqfc/Barry.Baker/models/ufswm-gocart/tests

dpsarmie · 2025-07-24T14:50:36Z

@dpsarmie I uploaded the test_changes.list

One note that I did have to add the path to the new input files in the AERO_ExtData.rc files for Ursa. Other machines will need this to be synced as well for the RT inputs.

Ok, sounds good, thanks. There will be some coordination needed with @jkbk2004 to have the inputs synced across machines and then you can revert those Ursa-specific changes. (If I'm understanding everything correctly)

bbakernoaa · 2025-07-24T15:50:40Z

@dpsarmie I uploaded the test_changes.list
One note that I did have to add the path to the new input files in the AERO_ExtData.rc files for Ursa. Other machines will need this to be synced as well for the RT inputs.

Ok, sounds good, thanks. There will be some coordination needed with @jkbk2004 to have the inputs synced across machines and then you can revert those Ursa-specific changes. (If I'm understanding everything correctly)

You are! Thanks @dpsarmie

FernandoAndrade-NOAA · 2025-07-29T17:46:35Z

Please resync and resolve conflicts, thank you.

jkbk2004 · 2025-07-29T21:18:58Z

@bbakernoaa @dpsarmie a question about location of new input files, ExtData/nexus. It sounds like under @[INPUTDATA_ROOT]/GOCART/p8/ExtData and @[INPUTDATA_ROOT]/GOCART/p8c_5d/ExtData. In current test system, a few spots where ExtData is linked up.

./fv3_conf/control_run.IN:  ln -sf  @[INPUTDATA_ROOT]/GOCART/p8/ExtData .
./fv3_conf/noahmp_run.IN:      ln -sf  @[INPUTDATA_ROOT]/GOCART/p8c_5d/ExtData .
./fv3_conf/cpld_control_run.IN:        ln -sf  @[INPUTDATA_ROOT]/GOCART/p8c_5d/ExtData .
./fv3_conf/lake_control_run.IN:  ln -sf  @[INPUTDATA_ROOT]/GOCART/ExtData .
./fv3_conf/wam_run.IN:  ln -sf  @[INPUTDATA_ROOT]/GOCART/p8/ExtData .

bbakernoaa · 2025-07-30T14:33:49Z

@jkbk2004 The files are currently placed in each machine in the fix directory for the global-workflow. We should copy these files to the respective @[INPUTDATA_ROOT]/GOCART/ExtData and @[INPUTDATA_ROOT]/GOCART/p8/ExtData locations as they are needed to test the configuration for GCAFSv1.

bbakernoaa · 2025-07-30T14:56:46Z

@bbakernoaa @dpsarmie a question about location of new input files, ExtData/nexus. It sounds like under @[INPUTDATA_ROOT]/GOCART/p8/ExtData and @[INPUTDATA_ROOT]/GOCART/p8c_5d/ExtData. In current test system, a few spots where ExtData is linked up.
./fv3_conf/control_run.IN:  ln -sf  @[INPUTDATA_ROOT]/GOCART/p8/ExtData .
./fv3_conf/noahmp_run.IN:      ln -sf  @[INPUTDATA_ROOT]/GOCART/p8c_5d/ExtData .
./fv3_conf/cpld_control_run.IN:        ln -sf  @[INPUTDATA_ROOT]/GOCART/p8c_5d/ExtData .
./fv3_conf/lake_control_run.IN:  ln -sf  @[INPUTDATA_ROOT]/GOCART/ExtData .
./fv3_conf/wam_run.IN:  ln -sf  @[INPUTDATA_ROOT]/GOCART/p8/ExtData .

what exactly is the question at hand?

Files needed to be synced

Three files will need to be copied (new data not in place of):

FENGSHA_New_Method_NESDISv1.1_9km.nc
FENGSHA_GVF_LAI2.nc
FENGSHA_2022_NESDIS_inputs_10km_v3.2.nc

The pick up location for the data is on URSA:

/scratch3/NCEPDEV/global/role.glopara/data/GEFS_ExtData/20250310/nexus/FENGSHA/FENGSHA_New_Method_NESDISv1.1_9km.nc
/scratch3/NCEPDEV/global/role.glopara/data/GEFS_ExtData/20250310/nexus/FENGSHA/FENGSHA_2022_NESDIS_inputs_10km_v3.2.nc
/scratch3/NCEPDEV/global/role.glopara/data/GEFS_ExtData/20250310/nexus/FENGSHA/FENGSHA_GVF_LAI2.nc

Copy to RT INPUTDATA_ROOT locations

Copy to all ExtData/dust locations (URSA locations shown as examples):

/scratch4/NAGAPE/epic/role-epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/GOCART/p8c_5d/ExtData/dust/
/scratch4/NAGAPE/epic/role-epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/GOCART/p8/ExtData/dust/
'/scratch4/NAGAPE/epic/role-epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/GEFS/ExtData/dust/'

bbakernoaa · 2025-07-30T16:43:38Z

@jkbk2004 do you want me to update the PR to assume these files are in the respective locations and not hard coded here?

jkbk2004 · 2025-07-30T17:03:07Z

./fv3_conf/lake_control_run.IN: ln -sf @[INPUTDATA_ROOT]/GOCART/ExtData .

@bbakernoaa All clear to me. I am rsyncing across machines. I think we need to clean up the line ./fv3_conf/lake_control_run.IN: ln -sf @[INPUTDATA_ROOT]/GOCART/ExtData . . It's not much to do with this pr. I will make sure.

jkbk2004 · 2025-07-30T17:13:39Z

@BrianCurtis-NOAA you can rsync from /scratch3/NAGAPE/epic/role.epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/GOCART/p8/ExtData/dust and p8c_5d/ExtData/dust

FernandoAndrade-NOAA · 2025-07-30T18:36:00Z

@jkbk2004 do you want me to update the PR to assume these files are in the respective locations and not hard coded here?

Yes please update the file paths, thank you.

Update to relative paths to support all machines

jkbk2004 · 2025-07-30T20:37:51Z

@bbakernoaa can you update tests/parm/gocart/AERO_ExtData.rc as well?

jkbk2004 · 2025-07-31T11:53:38Z

@BrianCurtis-NOAA We need /scratch3/NAGAPE/epic/role.epic/UFS-WM_RT/NEMSfv3gfs/input-data-20250507/GEFS/ExtData/dust for cpld_control_gefs_intel.

BrianCurtis-NOAA · 2025-07-31T13:46:09Z

@jkbk2004 can you ensure the PR contains updated input-data change information, so that anyone who comes back to this PR knows what the exact changes were?

DeniseWorthen · 2025-07-31T14:00:59Z

And a good commit message would also help.

BrianCurtis-NOAA · 2025-07-31T15:36:35Z

On WCOSS2 cpld_control_gefs_intel a bunch of:

pe=00258 FAIL at line=01913    ExtDataGridCompMod.F90                   <File /ExtData/dust/FENGSHA_2022_NESDIS_inputs_10km_v3.2.nc not found>

Yet I have the file:

emc.nems@clogin09:/lfs/h2/emc/nems/noscrub/emc.nems/RT/NEMSfv3gfs/input-data-20250507> ls -alh GEFS/ExtData/dust/
total 689M
drwxr-sr-x 2 emc.nems nems 4.0K Jul 31 11:36 .
drwxrwsr-x 8 emc.nems nems 4.0K Jul 31 11:34 ..
-rw-r--r-- 1 emc.nems nems  57M Jul 31 11:36 FENGSHA_2022_NESDIS_inputs_10km_v3.2.nc
-rw-r--r-- 1 emc.nems nems 126M Jul 31 11:36 FENGSHA_GVF_LAI2.nc
-rw-r--r-- 1 emc.nems nems 508M Jul 31 11:36 FENGSHA_New_Method_NESDISv1.1_9km.nc

jkbk2004 · 2025-07-31T15:39:25Z

@BrianCurtis-NOAA @FernandoAndrade-NOAA fixed /ExtData issue.

{{git.username}} added 4 commits July 21, 2025 10:46

Update aerosol parameter files for improved dust and organic carbon m…

6c1dd18

…odeling to be inline with GCAFSv1

Update GOCART subproject commit reference to v2.4.3

1ffbad3

Refactor CA2G_instance_CA.oc.rc for Organic Carbon parameters and upd…

fb142b9

…ate related settings

Update aerosol parameter files for Organic Carbon and Sea Salt modeli…

93813e5

…ng, including wet removal scheme adjustments

dpsarmie added Baseline Updates Current baselines will be updated. Priority: High input data change Input data change labels Jul 21, 2025

JessicaMeixner-NOAA mentioned this pull request Jul 22, 2025

Update UFS model with physics updates for GFSv17 NOAA-EMC/global-workflow#3840

Open

15 tasks

Rollback

be1f8e2

JessicaMeixner-NOAA moved this to In Progress in GFS v17 Jul 22, 2025

JessicaMeixner-NOAA added this to GFS v17 Jul 22, 2025

bbakernoaa and others added 2 commits July 22, 2025 11:34

Update aerosol and carbon parameter files to include wet removal sche…

2aa1836

…mes and adjust file paths for consistency

Merge branch 'develop' into feature/gocart-update

3490e53

bbakernoaa marked this pull request as ready for review July 22, 2025 16:16

bbakernoaa added 2 commits July 24, 2025 14:39

update for URSA tests

6418caa

upload test_changes and RegrissionTests_ursa

c79ef4d

BrianCurtis-NOAA mentioned this pull request Jul 29, 2025

Add -check all and -ftrapuv to all Intel DEBUG builds #2789

Open

13 tasks

bbakernoaa and others added 2 commits July 29, 2025 15:15

Merge branch 'develop' into feature/gocart-update

e6d6bd7

Update bl_date.conf

47bb167

Update AERO_ExtData.rc

a184543

Update to relative paths to support all machines

Update AERO_ExtData.rc

6057e5f

jkbk2004 added jenkins-ort run ORT testing In Testing The PR that is currently in testing stages labels Jul 31, 2025

add derecho RT log: passed

07ec150

add gaeaC6 RT log passed

6cfa733

Fix /ExtData issue: AERO_ExtData.rc

1c8be5a

more fixes dust file path: Update AERO_ExtData.rc

e810310

Update GOCART to v2.4.3 #2819

Are you sure you want to change the base?

Update GOCART to v2.4.3 #2819

Uh oh!

Conversation

bbakernoaa commented Jul 21, 2025 • edited by FernandoAndrade-NOAA Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Commit Queue Requirements:

Description:

Updates to Dust Parameterization:

Wet Removal Scheme Enhancements:

File and Parameter Reassignments:

Commit Message:

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

Documentation:

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:

Testing Log:

Uh oh!

dpsarmie commented Jul 21, 2025

Uh oh!

JessicaMeixner-NOAA commented Jul 22, 2025

Uh oh!

bbakernoaa commented Jul 22, 2025

Uh oh!

dpsarmie commented Jul 22, 2025

Uh oh!

bbakernoaa commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dpsarmie commented Jul 24, 2025

Uh oh!

bbakernoaa commented Jul 24, 2025

Uh oh!

FernandoAndrade-NOAA commented Jul 29, 2025

Uh oh!

jkbk2004 commented Jul 29, 2025

Uh oh!

bbakernoaa commented Jul 30, 2025

Uh oh!

bbakernoaa commented Jul 30, 2025 • edited by jkbk2004 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files needed to be synced

The pick up location for the data is on URSA:

Copy to RT INPUTDATA_ROOT locations

Uh oh!

bbakernoaa commented Jul 30, 2025

Uh oh!

jkbk2004 commented Jul 30, 2025

Uh oh!

jkbk2004 commented Jul 30, 2025

Uh oh!

FernandoAndrade-NOAA commented Jul 30, 2025

Uh oh!

jkbk2004 commented Jul 30, 2025

Uh oh!

jkbk2004 commented Jul 31, 2025

Uh oh!

BrianCurtis-NOAA commented Jul 31, 2025

Uh oh!

DeniseWorthen commented Jul 31, 2025

Uh oh!

BrianCurtis-NOAA commented Jul 31, 2025

Uh oh!

jkbk2004 commented Jul 31, 2025

Uh oh!

Uh oh!

bbakernoaa commented Jul 21, 2025 •

edited by FernandoAndrade-NOAA

Loading

bbakernoaa commented Jul 24, 2025 •

edited

Loading

bbakernoaa commented Jul 30, 2025 •

edited by jkbk2004

Loading