-
Notifications
You must be signed in to change notification settings - Fork 271
[email protected] / CPE PrgEnv-intel/8.6.0 stack #2847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[email protected] / CPE PrgEnv-intel/8.6.0 stack #2847
Conversation
@rickgrubin-noaa Is this PR ready for review, or is there further work to do? |
It's been ready since August 1 (initial filing). Branch is synced with |
Fix typo in MODULEPATH
Fix stack compiler type to load
Require libfabric/1.20.1
Fix stack name, force libfabric/1.20.1
Fixes for gaeac6 OS upgrade
Remove module reset for gaeac6
Updates for new OS
what is the timeline to merge this? the upgrade from the intel classic to oneapi stack resolves issues for high-resolution tests (@JessicaMeixner-NOAA), among some other issues on c6. |
I was actually able to run with the old version of spack-stack after changing an environment variable. |
@ulmononian I was going to test on Ursa, but then it looked like @rickgrubin-noaa was added several more commits, and the control_c48 I ran failed, likely because he was in the midst of updating. If the PR is complete, then I will get back to testing it, and we can move it to "Schedule if everything passes. We have four PRs lined up already for this week, so it would go in on Friday at the earliest unless it can be combined with another PR. Let me know your thoughts on that. |
@gspetro-NOAA the changes are strictly for |
@rickgrubin-noaa Sorry-that's what I meant. I did try to test on Gaea C6, and the initial test I tried failed, but you were suddenly pushing a bunch of changes. Are you done now? |
Yes; done and successfully tested last week. |
would be great to merge friday or shortly after. it's fine to combine this with another PR if that helps expedite the process and reduce resource usage. thank you! |
The default compiler on Gaea C6 is now intel/2025.2, which is supposed to fix the bug causing MOM6 to fail to compile with ifx. Would it be possible to recompile the spack-stack with this compiler so that we can finally start testing the model using both Fortran and C/C++ LLVM based compilers. |
@DusanJovic-NOAA there are some known bugs in |
@rickgrubin-noaa When I run the If this is a baseline changing PR, we normally need you to run the full RT suite ( |
@gspetro-NOAA did control_c48 fail in the baseline comparison step or elsewhere? this is really only a compiler/lib change, but baselines could be altered. we can run the full suite without -c and share the logs if that will help. |
|
@ulmononian Yes, it failed in the comparison stage, which is expected for a compiler change, as @RatkoVasic-NOAA said. However, there was some confusion because this is listed as a non-baseline changing PR. It doesn't matter the reason the baselines change; if they change for any reason, it's a baseline changing PR. On the CM side, Ratko's right that before merging, we would run with the -c command to regenerate baselines. Then there are a few other steps we take. However, this only occurs after the developer has run the full RT suite (
In short, what we need is for @rickgrubin-noaa to run the full RT suite without |
I ran the RTs on Gaea C6, and the tests that fail are expected failures. Failures are either:
Note that |
This has been combined into #2882 |
Commit Queue Requirements:
Description:
This PR updates the gaeac6
Intel
modulefiles forspack-stack [email protected] / CPE PrgEnv-intel/8.6.0
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
No documentation change necessary as documentation does not specifically reference making changes host-specific modulefiles, rather only how to load them, e.g. 3.5.1. Loading the Required Modules
Changes
Regression Test Changes (Please commit test_changes.list):
See attached file
RegressionTests_weekly_gaeac6.log
generated via./rt.sh -a epic -r -w
Note that file
test_changes.list
waslength=0
for./rt.sh -a epic -r -c
and./rt.sh -a epic -r -w
./rt.sh -a epic -r -c
followed by./rt.sh -a epic -r -m
generated 100%successful comparisons.RegressionTests_weekly_gaeac6.log
Input data Changes:
Library Changes/Upgrades:
Required
Testing Log: