Skip to content

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Sep 11, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR combines two UWM PRs into one for merge queue purposes:

  1. (Original) This PR updates ufs/dev to the top of NCAR/main and provides a means to control some Thompson MP parameters via namelist. See Sync from NCAR/main + Thompson params ccpp-physics#309 for a more complete description of the physics changes.
  2. (Combined) This PR updates the gaeac6 Intel modulefiles for spack-stack [email protected] / CPE PrgEnv-intel/8.6.0 - this is the work of @rickgrubin-noaa

Commit Message:

* UFSWM - Sync from NCAR/main + Thompson params + update gaeac6 Intel modulefiles for [email protected] / CPE PrgEnv-intel/8.6.0 stack
  * FV3 - Sync from NCAR/main + Thompson params
    * ccpp-physics - Sync from NCAR/main + Thompson params 

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • No documentation update is required for this PR. These are mainly minor physics code changes with no scientific updates.

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

  • None.

Library Changes/Upgrades:


Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@gspetro-NOAA gspetro-NOAA added the No Baseline Change No Baseline Change label Sep 18, 2025
@gspetro-NOAA gspetro-NOAA moved this to Evaluating in PRs to Process Sep 18, 2025
@gspetro-NOAA
Copy link
Collaborator

@grantfirl Just confirming--this PR is ready to schedule, correct?

@grantfirl
Copy link
Collaborator Author

@grantfirl Just confirming--this PR is ready to schedule, correct?

@gspetro-NOAA Yes indeed.

@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review/Schedule in PRs to Process Sep 18, 2025
@gspetro-NOAA
Copy link
Collaborator

@grantfirl Thanks for bringing this up to date! Could you merge in contents of #2847? We'd like to combine them since that one is a simple modulefile update with baseline changes only on Gaea C6. We'll save #2880 and #2881 till next week.

@grantfirl
Copy link
Collaborator Author

@grantfirl Thanks for bringing this up to date! Could you merge in contents of #2847? We'd like to combine them since that one is a simple modulefile update with baseline changes only on Gaea C6. We'll save #2880 and #2881 till next week.

@gspetro-NOAA Sure. If necessary, I can create copies of #2880 in my fork for merging/testing purposes if we really want to get this work in before Dom gets back too.

@gspetro-NOAA
Copy link
Collaborator

Thanks! I think it's better just to skip to this PR w/#2847 combined in so that if there are any questions/concerns, we won't be stuck midway on the other two.

@grantfirl grantfirl changed the title Sync from NCAR/main + Thompson params Sync from NCAR/main + Thompson params + [email protected] / CPE PrgEnv-intel/8.6.0 stack Oct 14, 2025
@gspetro-NOAA gspetro-NOAA added Baseline Updates Current baselines will be updated. and removed No Baseline Change No Baseline Change labels Oct 14, 2025
@grantfirl
Copy link
Collaborator Author

grantfirl commented Oct 14, 2025

Note that the control_p8_rrtmgp_rad32 intel should probably change baselines on Gaea too, although it isn't included in the test_changes.list file since that file was grabbed from #2847 that didn't run control_p8_rrtmgp_rad32 intel since it was added in #2823 that was just merged.

@gspetro-NOAA gspetro-NOAA added No Baseline Change No Baseline Change Baseline Updates Current baselines will be updated. and removed Baseline Updates Current baselines will be updated. No Baseline Change No Baseline Change labels Oct 14, 2025
@gspetro-NOAA
Copy link
Collaborator

Note: Baselines only change on GaeaC6. On other platforms, the 20251014 baseline should just be a symlink to the 20251007 baseline.

@gspetro-NOAA gspetro-NOAA added the In Testing The PR that is currently in testing stages label Oct 14, 2025
@FernandoAndrade-NOAA FernandoAndrade-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing labels Oct 14, 2025
@FernandoAndrade-NOAA FernandoAndrade-NOAA removed the jenkins-ort run ORT testing label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. In Testing The PR that is currently in testing stages Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

Status: Schedule

Development

Successfully merging this pull request may close these issues.

Update gaea-c6 Intel modulefiles to support [email protected] [email protected] / CPE PrgEnv-intel/8.6.0

4 participants