-
Notifications
You must be signed in to change notification settings - Fork 2
Update dependencies, Node 24, and CI #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, Node 24, and CI #282
Conversation
- Update all dependencies to latest versions. - Update .nvmrc to 24. - Update CI to test on Node 22 and 24. - Remove ts-node. - Fix ESLint config to globally ignore dist. - Revert changes to CSVFormatter.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates project dependencies, upgrades from Node 22 to Node 24, updates the CI matrix to test both Node 22 and 24, and fixes the ESLint configuration structure.
Key Changes:
- Major dependency updates including TypeScript ESLint v8, ESLint v9, and TypeScript v5.9
- Node version upgrade from 22 to 24 in
.nvmrcand default CI workflow - CI matrix expanded to test both Node 22.x and 24.x
- ESLint config fixed to use proper flat config format with ignores
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates all dependencies with newer versions, including major updates to ESLint tooling |
| package.json | Updates dependency versions, removes ts-node, updates TypeScript and ESLint packages |
| eslint.config.js | Fixes configuration structure by moving ignores to proper position in flat config |
| .nvmrc | Updates Node version from 22 to 24 |
| .github/workflows/ci.yml | Updates Node version to 24 and adds matrix testing for Node 22 and 24 |
| lib/formatters/csv_formatter.ts | Reformats comment placement (cosmetic change) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "dependencies": { | ||
| "commander": "^14.0.0", | ||
| "csv-stringify": "^6.5.0" | ||
| "commander": "^14.0.2", | ||
| "csv-stringify": "^6.6.0" | ||
| }, |
Copilot
AI
Jan 1, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package.json should include an "engines" field to specify the minimum Node.js version requirement. Since this PR upgrades to Node 24 and removes support for Node 22 in the primary CI workflow, users should be informed about the required Node.js version. Consider adding: "engines": { "node": ">=22" } to ensure compatibility expectations are clear.
Updated dependencies, upgraded to Node 24, updated CI matrix, fixed ESLint config.
PR created automatically by Jules for task 16955452050662043994 started by @bmesuere