Skip to content

Update dependencies, Node 24, and CI #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmesuere merged 1 commit into from
Jan 1, 2026
Merged

Update dependencies, Node 24, and CI #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: 22.x
node-version: 24.x
cache: yarn
- name: Install dependencies
run: |
Expand All @@ -25,12 +25,15 @@ jobs:
test:
name: Test
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [22.x, 24.x]
steps:
- uses: actions/checkout@v4
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: 22.x
node-version: ${{ matrix.node-version }}
cache: yarn
- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22
24
4 changes: 2 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import tseslint from "typescript-eslint";


export default [
{ ignores: ["dist/"] },
{ languageOptions: { globals: globals.node } },
pluginJs.configs.recommended,
...tseslint.configs.recommended,
Expand All @@ -14,7 +15,6 @@ export default [
{ argsIgnorePattern: "^_", caughtErrors: "none" }
],
"@typescript-eslint/ban-ts-comment": "off",
},
ignores: ["dist/"]
}
}
];
3 changes: 2 additions & 1 deletion lib/formatters/csv_formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ export class CSVFormatter extends Formatter {
flatten(data: { [key: string]: unknown }[]): { [key: string]: unknown }[] {
const prefixes = ["ec", "go", "ipr"];
prefixes.forEach(prefix => {
if (this.getKeys(data).includes(prefix)) {// @ts-ignore
if (this.getKeys(data).includes(prefix)) {
// @ts-ignore
const keys = Object.keys(data[0][prefix][0]);
data.forEach(row => {
keys.forEach(key => {
Expand Down
23 changes: 11 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,21 @@
"dist"
],
"dependencies": {
"commander": "^14.0.0",
"csv-stringify": "^6.5.0"
"commander": "^14.0.2",
"csv-stringify": "^6.6.0"
},
Comment on lines 29 to 32
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json should include an "engines" field to specify the minimum Node.js version requirement. Since this PR upgrades to Node 24 and removes support for Node 22 in the primary CI workflow, users should be informed about the required Node.js version. Consider adding: "engines": { "node": ">=22" } to ensure compatibility expectations are clear.

Copilot uses AI. Check for mistakes.
"devDependencies": {
"@eslint/js": "^9.5.0",
"@types/node": "^24.0.8",
"@typescript-eslint/eslint-plugin": "^7.13.1",
"@typescript-eslint/parser": "^7.13.1",
"eslint": "9.x",
"globals": "^16.0.0",
"@eslint/js": "^9.39.2",
"@types/node": "^24",
"@typescript-eslint/eslint-plugin": "^8.51.0",
"@typescript-eslint/parser": "^8.51.0",
"eslint": "9.39.2",
"globals": "^17.0.0",
"mock-stdin": "^1.0.0",
"np": "^10.0.7",
"ts-node": "^10.9.2",
"tsx": "^4.15.6",
"typescript": "^5.4.5",
"typescript-eslint": "^8.16.0",
"tsx": "^4.21.0",
"typescript": "^5.9.3",
"typescript-eslint": "^8.51.0",
"vitest": "^4.0.16"
}
}
Loading