Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Upload, Part 2: Update File Delete/Update endpoints #251

Open
wants to merge 2 commits into
base: ryan-jamie/file-upload
Choose a base branch
from

Conversation

RyanSh3n
Copy link

@RyanSh3n RyanSh3n commented Apr 25, 2024

Notion ticket link

Implement File Upload

Implementation description

  • Added delete, update file endpoints
  • Updated the delete, update methods for intake objects to include the file endpoints

Steps to test

  1. Use Postman to test delete and update endpoints
  2. For DELETE: use http://localhost:5000/intake?intake_id={file_id}
  3. For PUT: use http://localhost:5000/intake/{file_id}
  4. replace file_id with the file to be deleted or updated

What should reviewers focus on?

  • the integration of the update and delete file endpoints into the regular update and delete intake endpoints

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant