Remove ExecutionPolicy template param from internal oneDPL buffers
#2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
force-pushed
the
dev/skopienko/remove_execution_policy_from_buffers
branch
from
79a700a to
e06d4c1
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/remove_execution_policy_from_buffers
branch
from
b2bce95 to
5cf5f59
Compare
danhoeflinger
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Yeah, this LGTM.
I think this in line with the offline decision to remove Policy from touching bricks, etc. where it is not needed.
If a future parallel backend requires ExecutionPolicy to be passed in, then we will need to figure out how to handle that then.
SergeyKopienko
deleted the
dev/skopienko/remove_execution_policy_from_buffers
branch
timmiesmith
pushed a commit
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove
ExecutionPolicytemplate param from internal oneDPL buffers as not required:__buffertemplate aliases;class __buffer_impl(both implementations);__bufferinstances in oneDPL code.