Removal ExecutionPolicy template parameter from bricks
#2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
force-pushed
the
dev/skopienko/remove_execution_policy_from_bricks
branch
from
bcf415f to
c7403a2
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/remove_execution_policy_from_bricks
branch
from
c7403a2 to
3faccca
Compare
SergeyKopienko
requested review from
danhoeflinger,
MikeDvorskiy,
akukanov and
rarutyun
This was referenced Mar 31, 2025
SergeyKopienko
force-pushed
the
dev/skopienko/remove_execution_policy_from_bricks
branch
from
2001e33 to
8120dcd
Compare
SergeyKopienko
changed the title
ExecutionPolicy template parameter from briksExecutionPolicy template parameter from bricks
SergeyKopienko
force-pushed
the
dev/skopienko/remove_execution_policy_from_bricks
branch
2 times, most recently
from
882230c to
e9c5745
Compare
SergeyKopienko
commented
Apr 11, 2025
SergeyKopienko
force-pushed
the
dev/skopienko/remove_execution_policy_from_bricks
branch
from
0a25533 to
9a4e2c8
Compare
…review comment: We have the specialization by a hetero tag, so we don't need std::enable_if_t here.
…x review comment: We have the specialization by a hetero tag, so we don't need std::enable_if_t here.
SergeyKopienko
force-pushed
the
dev/skopienko/remove_execution_policy_from_bricks
branch
from
28626c9 to
61b5e06
Compare
…l_n - fix review comment: We have the specialization by a hetero tag, so we don't need std::enable_if_t here." This reverts commit 61b5e06.
…l - fix review comment: We have the specialization by a hetero tag, so we don't need std::enable_if_t here." This reverts commit d5f09f3.
…::__internal::__is_host_dispatch_tag_v<_Tag>> from struct __brick_copy, struct __brick_copy_n, struct __brick_move" This reverts commit 09ddfbb.
SergeyKopienko
deleted the
dev/skopienko/remove_execution_policy_from_bricks
branch
This was referenced Apr 17, 2025
timmiesmith
pushed a commit
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove
ExecutionPolicytemplate parameter from bricks according to our offline discussion.Other linked PR's: #2152, #2153
Issue: #2110