Replacement of internal lambda in oneDPL code by functional objects
#2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2025
SergeyKopienko
force-pushed
the
dev/skopienko/move_lambdas_out
branch
6 times, most recently
from
162526f to
78250d2
Compare
SergeyKopienko
requested review from
MikeDvorskiy,
danhoeflinger,
mmichel11 and
dmitriy-sobolev
SergeyKopienko
force-pushed
the
dev/skopienko/move_lambdas_out
branch
6 times, most recently
from
0db580a to
5813665
Compare
SergeyKopienko
changed the title
lambda code as functional objectslambda's in oneDPL code by functional objects
SergeyKopienko
changed the title
lambda's in oneDPL code by functional objectslambdas in oneDPL code by functional objects
SergeyKopienko
changed the title
lambdas in oneDPL code by functional objectslambda in oneDPL code by functional objects
SergeyKopienko
commented
Mar 31, 2025
SergeyKopienko
commented
Mar 31, 2025
SergeyKopienko
force-pushed
the
dev/skopienko/move_lambdas_out
branch
from
7b3e2be to
c0ca621
Compare
SergeyKopienko
changed the title
lambda in oneDPL code by functional objectslambda in oneDPL code by functional objects
…eview comment: using one __pattern_transform_unary_op instead of __pattern_for_each_fn
…eview comment: using __pattern_transform_unary_op instead of __pattern_find_if_pred
…eview comment: using __pattern_transform_unary_op instead of __pattern_any_of_pred
…eview comment: using __pattern_transform_binary_op instead of __pattern_equal_pred and __pattern_search_pred
…eview comment: using __pattern_transform_fn instead of __pattern_adjacent_find_ranges_pred
…eview comment: using __pattern_transform_fn instead of __pattern_is_sorted_pred
…eview comment: using __pattern_transform_unary_op instead of __pattern_count_if_pred
…eview comment: using __pattern_transform_unary_op instead of __pattern_copy_if_ranges_pred
…eview comment: using __pattern_transform_binary_op instead of __pattern_merge_comp
…eview comment: using __pattern_transform_binary_op instead of __pattern_min_element_comp
…eview comment: using __transform_functor instead of __pattern_adjacent_difference_op_caller_fn
…ment: using __transform_functor instead of __pattern_adjacent_difference_op_caller_fn
SergeyKopienko
force-pushed
the
dev/skopienko/move_lambdas_out
branch
from
7284c47 to
97915de
Compare
…view comment: using __transform_functor instead of __transform_fn and __transform_fn2" This reverts commit 0ceb34b.
… - fix review comment: using __transform_functor instead of __pattern_adjacent_difference_op_caller_fn" This reverts commit a3d3e30. # Conflicts: # include/oneapi/dpl/pstl/hetero/numeric_impl_hetero.h
…lf review comment: move __parallel_reduce_by_segment_fallback_fn1 and __parallel_reduce_by_segment_fallback_fn2 into __internal namespace
|
I think, we should the device copyable trait specialization (see sycl_traits.h) for the new functors, probably not for all, but for mostly. |
MikeDvorskiy
approved these changes
Apr 15, 2025
This was referenced Apr 17, 2025
timmiesmith
pushed a commit
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we reimplements
lambdacode as functional objects according to our offline discussion.Other linked PR's: #2148, #2152