-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Vite 5.3.3 #19646
chore: Vite 5.3.3 #19646
Conversation
@@ -10,7 +10,7 @@ | |||
"license": "Apache-2.0", | |||
"dependencies": {}, | |||
"devDependencies": { | |||
"vite": "5.3.1", | |||
"vite": "5.3.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off topic; just wanted to mention it here cause perfect place..
I noticed that when running clean install vaadin downgrades vite in 24.4 from 5.3.1 to 5.2.13 again.. once I start the application it's 5.3.1 again but it is really weird and always creates stale changes in git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds completely off topic but is it vaadin:prepare-frontend
that downgrades it? Sounds a bit like you somehow get an old Flow version on the classpath for the build part but when running the app you have the correct version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah prepare-frontend runs default. You are definitly correct with your assumption, only thing that made me question myself: No addons; just Vaadin 24.4 and dependency:tree looks good. Just wanted to mention it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be that mvn dependency:resolve-plugins
would show something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quickest fix for this issue is probably to pin Flow version in vaadin-maven-plugin
, so it will at least be compatible with the platform.
Ping @ZheSun88
However, I suppose the proper solution would be making Flow maven plugin mojos be executed with project classpath instead of the plugin classpath, as discussed in #19010
Quality Gate passedIssues Measures |
* chore: Vite 5.3.2 * Update package.json
* chore: Vite 5.3.2 * Update package.json Co-authored-by: Artur <[email protected]>
No description provided.