Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Vite 5.3.3 #19646

Merged
merged 3 commits into from
Jul 3, 2024
Merged

chore: Vite 5.3.3 #19646

merged 3 commits into from
Jul 3, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jun 27, 2024

No description provided.

Copy link

github-actions bot commented Jun 27, 2024

Test Results

1 127 files  ± 0  1 127 suites  ±0   1h 25m 34s ⏱️ - 1m 14s
7 298 tests ± 0  7 248 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 616 runs   - 13  7 556 ✅  - 13  60 💤 ±0  0 ❌ ±0 

Results for commit a630820. ± Comparison against base commit 455dd60.

♻️ This comment has been updated with latest results.

@@ -10,7 +10,7 @@
"license": "Apache-2.0",
"dependencies": {},
"devDependencies": {
"vite": "5.3.1",
"vite": "5.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off topic; just wanted to mention it here cause perfect place..

I noticed that when running clean install vaadin downgrades vite in 24.4 from 5.3.1 to 5.2.13 again.. once I start the application it's 5.3.1 again but it is really weird and always creates stale changes in git.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds completely off topic but is it vaadin:prepare-frontend that downgrades it? Sounds a bit like you somehow get an old Flow version on the classpath for the build part but when running the app you have the correct version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah prepare-frontend runs default. You are definitly correct with your assumption, only thing that made me question myself: No addons; just Vaadin 24.4 and dependency:tree looks good. Just wanted to mention it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be that mvn dependency:resolve-plugins would show something else

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly nothing really obvious; only thing that looked a bit off is the 24.4.1 of flow in 24.4.3 instead of the 24.4.2 mentioned in the release notes:

grafik

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quickest fix for this issue is probably to pin Flow version in vaadin-maven-plugin, so it will at least be compatible with the platform.
Ping @ZheSun88

However, I suppose the proper solution would be making Flow maven plugin mojos be executed with project classpath instead of the plugin classpath, as discussed in #19010

@Artur- Artur- requested a review from mshabarov July 2, 2024 08:56
@Artur- Artur- changed the title chore: Vite 5.3.2 chore: Vite 5.3.3 Jul 3, 2024
Copy link

sonarcloud bot commented Jul 3, 2024

@mshabarov mshabarov merged commit 096f402 into main Jul 3, 2024
25 of 30 checks passed
@mshabarov mshabarov deleted the Artur--patch-12 branch July 3, 2024 08:04
vaadin-bot pushed a commit that referenced this pull request Jul 3, 2024
* chore: Vite 5.3.2

* Update package.json
vaadin-bot added a commit that referenced this pull request Jul 3, 2024
* chore: Vite 5.3.2

* Update package.json

Co-authored-by: Artur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants