Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Vite 5.3.3 #19646

Merged
merged 3 commits into from
Jul 3, 2024
Merged

chore: Vite 5.3.3 #19646

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fce4965
chore: Vite 5.3.2
Artur- Jun 27, 2024
6f6723a
Merge branch 'main' into Artur--patch-12
Artur- Jul 2, 2024
a630820
Update package.json
Artur- Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-server/src/main/resources/com/vaadin/flow/server/frontend/dependencies/vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"license": "Apache-2.0",
"dependencies": {},
"devDependencies": {
"vite": "5.3.1",
"vite": "5.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off topic; just wanted to mention it here cause perfect place..

I noticed that when running clean install vaadin downgrades vite in 24.4 from 5.3.1 to 5.2.13 again.. once I start the application it's 5.3.1 again but it is really weird and always creates stale changes in git.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds completely off topic but is it vaadin:prepare-frontend that downgrades it? Sounds a bit like you somehow get an old Flow version on the classpath for the build part but when running the app you have the correct version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah prepare-frontend runs default. You are definitly correct with your assumption, only thing that made me question myself: No addons; just Vaadin 24.4 and dependency:tree looks good. Just wanted to mention it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be that mvn dependency:resolve-plugins would show something else

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly nothing really obvious; only thing that looked a bit off is the 24.4.1 of flow in 24.4.3 instead of the 24.4.2 mentioned in the release notes:

grafik

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quickest fix for this issue is probably to pin Flow version in vaadin-maven-plugin, so it will at least be compatible with the platform.
Ping @ZheSun88

However, I suppose the proper solution would be making Flow maven plugin mojos be executed with project classpath instead of the plugin classpath, as discussed in #19010

"@vitejs/plugin-react": "4.3.1",
"@preact/signals-react-transform": "0.3.1",
"@rollup/plugin-replace": "5.0.7",
Expand Down
Loading