-
Notifications
You must be signed in to change notification settings - Fork 2
ナビゲーションリファクタリング / Navigation Refactoring #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 41 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
8eacc80
Update _navigation.scss
mtdkei 5b6bae9
Update _navigation.scss
mtdkei ab45ab3
Update _navigation.scss
mtdkei 6e591cb
Update _navigation.scss
mtdkei 3b1c977
Update _navigation.scss
mtdkei e4ec3ec
Update _navigation.scss
mtdkei 3b19116
Update readme.txt
mtdkei 2aa3f82
Update _navigation.scss
mtdkei 3def443
Update _navigation.scss
mtdkei a062ecf
Merge branch 'master' into fix/core-navigation-submenu-design
kurudrive c04b354
Fixed a typo
mtdkei 59ca82f
Fix SCSS for submenus
mtdkei 7ddf10e
gapが効かなかったのを修正
goutetsuguma 153ed68
Merge branch 'master' into fix/core-navigation-submenu-design
goutetsuguma 9c0c574
Merge branch 'master' into fix/core-navigation-submenu-design
d066dce
Fix: footer navigation
54f754c
delete space
kurudrive 5be2534
Merge branch 'master' into fix/core-navigation-submenu-design
kurudrive 42e5366
Merge branch 'master' into fix/core-navigation-submenu-design
kurudrive 06fd940
Merge branch 'master' into fix/core-navigation-submenu-design
kurudrive 1a2aa2b
Merge branch 'master' into fix/core-navigation-submenu-design
kurudrive 5a0827f
縦ナビゲーション作り直し
kurudrive 6fbe910
Merge branch 'master' into change/navigation-vertical
kurudrive f4d4a8b
公開画面側の調整まで
kurudrive 4358061
テキストインライン調整
kurudrive 5bc7c6c
change css file name
kurudrive 67afdc6
リファクタリング
kurudrive aa5d8fc
縦メニューの孫階層用のアイコンの位置を調整
kurudrive 918a46f
コメントの移動のみ
kurudrive b636965
編集画面調整
kurudrive 79489ee
Merge branch 'master' into change/navigation-vertical-a
kurudrive 4a671b0
縦方向折りたたみなし追加
kurudrive af2144f
メニュースタイル名調整
kurudrive 73f5afc
ヘッダーのサブナビゲーション調整
kurudrive ed0b833
ナビゲーション 編集画面での調整など
kurudrive f4d9be8
縦の常時の調整がまだ
kurudrive 6089f4c
オーバーレイ時の調整
kurudrive b4bf2e3
update readme
kurudrive 0204b20
vh を svh に変更
kurudrive 868d56d
vh を svh に変更
kurudrive cc0f7bd
[ ナビゲーション ] 編集画面での不具合修正
kurudrive 62c7c88
横メニューで縦スタイルを指定した時にサブナビゲーションに色がつく不具合を修正修正
kurudrive 588d8da
[ ナビゲーション ] 背景色ありの時にコアのCSSによって下階層の開始位置が下にいったり右にいったりする処理を上書き
kurudrive a825593
ナビゲーション 文字サイズ調整
kurudrive 20d3b7e
Merge branch 'master' into change/navigation-vertical-a
kurudrive ba8d26b
update readme
kurudrive 32c271e
update readme
kurudrive 8a78890
update readme
kurudrive File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメント欄のコードをコピペしたナビゲーションでは設定がコピーされるので問題ないのですが、
新規でナビゲーションを設置した時に、方向が「横」のまま、スタイルを「Vertical with HR No Fold」や「Vertical with HR」にすると、下階層がキーカラーになります。方向を「縦」にすれば良い話なのですが、スタイルを選択した時にすでにナビが縦並びになるため、ユーザーは気付きにくいかもしれないと思いましたので、以下のスタイルも:not()指定に入れてしまうのはどうでしょうか。
is-style-nav--vertical-with-hr-and-no-fold
とis-style-nav--vertical-with-hr
変なことを言っていたらすみません!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goutetsuguma ありがとうございます。修正しました!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下階層に色がつかないことを確認しました!ありがとうございました!