Compatibility with Ansible 12 (part 2) #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored tasks to handle missing or undefined SSH key data more robustly. Improved default handling for loop variables and conditions, ensuring correct fingerprint assignment and comparison regardless of input case or missing values.
Ensures the loop over droplet_result.results explicitly converts the selection to a list and updates the conditional to check for non-empty lists, improving reliability when processing DigitalOcean droplet data.
Updated the loop and conditional logic to properly filter and handle server results in the Hetzner cloud resources role. This ensures that only defined server data is processed and improves task reliability.
Ensures selectattr results are converted to lists for proper looping and condition evaluation in aws.yml. This improves reliability when processing server_result data.
Wrap selectattr results with list() in loops and conditions to ensure proper iteration and length checks. This improves reliability when processing server_result.results in Ansible tasks for Azure resources.
Ensure selectattr results are converted to lists before looping and update conditional to check for non-empty lists. This improves reliability when processing server results with network interfaces.
This was referenced Oct 25, 2025
Closed
Added default value handling for pgbackrest_repo_host and ensured stanza creation only runs when pgbackrest group is present. This improves robustness and prevents errors when variables or groups are missing.
Updated pg_new_packages to use map with regex_replace for correct package name substitution and ensured the loop uses a list in the upgrade tasks.
Replaces direct usage of groups['pgbackrest'][0] with a new variable pgbackrest_delegate for task delegation. This improves readability and maintainability by centralizing the delegate host selection.
Temporarily disabled several Linux distros in molecule_pg_upgrade.yml due to 'rsync: connection unexpectedly closed' errors in the GitHub CI environment. Added a TODO note for future investigation.
Refines conditional logic in stanza_create.yml to ensure tasks only run when pgbackrest_delegate is defined. Updates delegate variable assignment to handle missing group gracefully, improving robustness in environments where the pgbackrest group may be absent.
Adds a conditional to the failed_when clause to ignore 'not found' errors when deleting DigitalOcean load balancers, preventing unnecessary task failures if the resource does not exist.
Replaces the use of 'replace' with 'map' and 'regex_replace' for looping over postgresql_packages, ensuring correct substitution of version strings during package removal in the upgrade role.
Replaces hardcoded delegate_to usage with a variable pgbackrest_delegate, improving flexibility and handling cases where the pgbackrest group may be empty. Also updates conditional checks to use default values for robustness.
Updated the usage of groups.get('pgbackrest') and related defaults in stanza_create.yml, pgbackrest_host.yml, and post_upgrade.yml to use the 'default' filter with 'true' and ensure proper type handling. This change improves robustness when the 'pgbackrest' group is missing or empty.
Refactored the Jinja template for instances_selflink to use a more compact inline object format, improving readability in the GCP resource automation task.
Updated the GCP cloud resource automation to parse the instances_selflink variable using from_json. This ensures the instances parameter is correctly interpreted as a JSON object when provisioning resources.
Changed the default Azure VM image offer to 'ubuntu-24_04-lts' and sku to 'server' for provisioning. This ensures new VMs use the latest Ubuntu LTS version by default.
There was a problem hiding this comment.
Pull Request Overview
This PR continues integration of Ansible 12 support by fixing compatibility issues discovered during testing. The changes primarily address how Ansible 12 handles filter results, requiring explicit list conversions and updated conditional checks for group existence.
Key changes:
- Replaced
replacefilter withmap('regex_replace')for proper list handling in Ansible 12 - Added explicit
| listconversions for filters that return generators instead of lists - Updated conditional checks to safely handle potentially undefined groups using
groups.get()
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| automation/roles/upgrade/tasks/post_upgrade.yml | Updates package list filtering and pgbackrest delegation to work with Ansible 12 |
| automation/roles/upgrade/tasks/packages.yml | Adds explicit list conversion for package installation loop |
| automation/roles/upgrade/defaults/main.yml | Changes package name replacement to use map filter instead of replace |
| automation/roles/update/tasks/pgbackrest_host.yml | Updates pgbackrest host delegation and group checks for Ansible 12 compatibility |
| automation/roles/pgbackrest/tasks/stanza_create.yml | Fixes pgbackrest delegation and adds safe group existence checks |
| automation/roles/cloud_resources/tasks/hetzner.yml | Adds list conversions for selectattr filter results |
| automation/roles/cloud_resources/tasks/gcp.yml | Fixes JSON parsing and adds list conversions for instance iteration |
| automation/roles/cloud_resources/tasks/digitalocean.yml | Improves conditional logic and adds error handling for load balancer deletion |
| automation/roles/cloud_resources/tasks/azure.yml | Changes default VM image from Ubuntu 22.04 to 24.04 and adds list conversions |
| automation/roles/cloud_resources/tasks/aws.yml | Adds list conversions for EC2 instance filtering |
| .github/workflows/molecule_pg_upgrade.yml | Temporarily disables RedHat-based distros due to rsync issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Introduced 'until', 'retries', and 'delay' parameters to ssh-keyscan tasks in pgbackrest, ssh_keys, and upgrade roles to improve robustness against transient SSH key scanning failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the integration of Ansible 12 support (#1279) and addresses the issues discovered during the testing.
Fixes #1318, #1319
Additionally