Reserve marker's space #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaumb
commented
Apr 29, 2024
schaumb
force-pushed
the
memory-footprint-v1
branch
from
6d256f8
to
a09888d
Compare
schaumb
force-pushed
the
memory-footprint-v1
branch
from
a09888d
to
d48b677
Compare
schaumb
commented
May 4, 2024
schaumb
commented
May 13, 2024
| Data::SeriesList subIds(subAxis.first); | ||
| if (subIds.split_by(mainAxisDims.first).empty()) | ||
| subAxisId = &subId; | ||
| subId = data.getId({subIds, subAxis.second}, index); |
There was a problem hiding this comment.
Note: The implementation of labelLevel on subAxis will skip common series with the mainAxis on area geometry (as before)
simzer
reviewed
May 13, 2024
simzer
reviewed
May 16, 2024
simzer
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.