Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve marker's space #521

Merged
merged 61 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
f1f24ad
Remove unordered_maps, reserve all marker's space. Remove static vectors
schaumb Apr 29, 2024
66d9957
Buckets contains marker pointers
schaumb Apr 29, 2024
cd4ec9c
Fix clang tidy
schaumb Apr 29, 2024
b38915e
Self review v1
schaumb Apr 30, 2024
7e937f3
Reuse and clear buckets.
schaumb Apr 30, 2024
dcf8ce5
fix clang-tidy and clang-format
schaumb Apr 30, 2024
d4cc999
Save categories too, MarkerId == itemId, shared cellinfo, simplify la…
schaumb Apr 30, 2024
d48b677
Some micro-opt + size opt
schaumb Apr 30, 2024
433ffe3
Fix mem-corr-s
schaumb May 2, 2024
68a7a4a
Add uniqueList index, add compare seriesIndex with dimension name
schaumb May 2, 2024
0902176
ClangTidy AST fix, make cellinfo
schaumb May 2, 2024
2c1be01
Call only once getId / channel / marker
schaumb May 2, 2024
7cc3253
Self review, sort markers secondly by index
schaumb May 2, 2024
b289d5b
self-review
schaumb May 2, 2024
06da3d5
Not calculate again main and sub axis id's
schaumb May 2, 2024
e353da5
Remove unused stackId
schaumb May 2, 2024
78e2c0f
Faster allocation on buckets
schaumb May 2, 2024
c9293ed
Refactor Channel/Channels, Options auto param getters
schaumb May 3, 2024
955eee0
Remove buckets from plot object. Make buckets impl unique_ptr. Self r…
schaumb May 5, 2024
5d9fb0a
Remove unused construction
schaumb May 6, 2024
9c77290
SpecLayout refactor
schaumb May 6, 2024
512f8c6
fix clang-tidy
schaumb May 6, 2024
2718603
Some more optimization
schaumb May 6, 2024
522a4fa
Remove SubSliceIndex
schaumb May 6, 2024
56b706d
clang-tidy
schaumb May 6, 2024
5317412
Interpolated -> remove count
schaumb May 6, 2024
295fa3b
clang-tidy
schaumb May 6, 2024
83977a1
Remove marker label common parts
schaumb May 7, 2024
4d2188c
Make cellinfo calculation optional as possible
schaumb May 7, 2024
9c96b11
Add changelog
schaumb May 7, 2024
a6c3259
Animator + ChannelStats refactor
schaumb May 8, 2024
92e1833
Remove interpolated combine parameter and rewrite visit and get arg t…
schaumb May 8, 2024
bc045b9
Remove/Replace all uint64_t
schaumb May 8, 2024
21f5fb1
Clang-tidy
schaumb May 8, 2024
99425ff
Self Review vol1
schaumb May 9, 2024
2cb5b2d
clang-tidy
schaumb May 9, 2024
8351c1f
Fix testcases
schaumb May 9, 2024
27d4ca4
Linearize DataCube::combinedSizeOf, DataCube::getId and DataCube::joi…
schaumb May 9, 2024
e4e363e
Merge marker's cell info
schaumb May 9, 2024
06143cd
Export index on disabled marker.
schaumb May 10, 2024
f4595ac
Remove string_view storage at MeasureAxis
schaumb May 10, 2024
97a8a85
Simplify code, reduce ~2k binary
schaumb May 10, 2024
2448164
clang-tidy hack...
schaumb May 10, 2024
8e29667
Fix uniqueList fuzzy const, merge event classes
schaumb May 10, 2024
2e10c3e
Use events replacement of functions
schaumb May 10, 2024
df9eeb0
fix test
schaumb May 10, 2024
36e1f46
Fix tests, refactor Filter, add changelog note
schaumb May 11, 2024
13f59f1
Fix clang-tidy
schaumb May 11, 2024
73e541e
Fix clang-tidy again...
schaumb May 11, 2024
b17d731
Make datacube only available from Plot constructor. Fix clang tidy again
schaumb May 8, 2024
7fba856
Clang-tidy...
schaumb May 12, 2024
0f2bea6
Remove std::any
schaumb May 12, 2024
ae5d1e2
Remove Event from ObjectRegistry
schaumb May 12, 2024
3a97065
Move speclayout calculation to plot.
schaumb May 13, 2024
ca0b1ae
self-review. Duplicate jsonize
schaumb May 13, 2024
99cfeec
Make independent ObjectRegistry
schaumb May 13, 2024
c1d7e1d
Merge remote-tracking branch 'origin/main'
schaumb May 14, 2024
0ddd834
Review: change interpolated get from bool to enum
schaumb May 14, 2024
8c8b56d
Review + clang-tidy
schaumb May 14, 2024
86857fd
Merge SpecMarker size to the variant shape
schaumb May 14, 2024
3402a37
rename 'interpolated' function based on review
schaumb May 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
- plugin: canvasRenderer - plugin for rendering the chart on a htmlcanvas compatible canvas
- hook: start - hook for starting the rendering loop
- hook: render - hook for rendering the chart
- Chart generation performance optimization: ~3x speed
- Maximum marker limit increased: ~2x count
- Reduced wasm binary size: ~3%

## [0.10.1] - 2024-03-12

Expand Down
6 changes: 1 addition & 5 deletions src/apps/weblib/cinterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@ const char *vizzu_errorMessage(APIHandles::Exception exceptionPtr,
realException =
static_cast<const std::bad_cast *>(exceptionPtr);
break;
case hash("bad_any_cast"):
realException =
static_cast<const std::bad_any_cast *>(exceptionPtr);
break;
case hash("bad_function_call"):
realException =
static_cast<const std::bad_function_call *>(
Expand Down Expand Up @@ -336,7 +332,7 @@ void removeEventListener(APIHandles::Chart chart,

void event_preventDefault(APIHandles::Event event)
{
return Interface::getInstance().preventDefaultEvent(event);
return Interface::preventDefaultEvent(event);
}

void chart_animate(APIHandles::Chart chart, void (*callback)(bool))
Expand Down
3 changes: 2 additions & 1 deletion src/apps/weblib/cinterface.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifndef LIB_CINTERFACE_H
#define LIB_CINTERFACE_H

#include <base/util/eventdispatcher.h>
#include <cstdint>
#include <typeinfo>

Expand All @@ -14,7 +15,7 @@ namespace APIHandles
using Any = const void *;
using Chart = const void *;
using Snapshot = const void *;
using Event = const void *;
using Event = Util::EventDispatcher::Params *;
using Animation = const void *;
using Exception = const void *;
using Canvas = const void *;
Expand Down
Loading