[Bug] avoid frequent lookup of the routing strategy env

[Iceber]

Pull Request Description

[Please provide a clear and concise description of your changes here]

There's no need to check the environment variables every time a request is processed.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[Iceber]

CheckEnvExists doesn't seem like the best name. Maybe rename it to LookupEnv or just use os.LookupEnv directly?

aibrix/pkg/utils/redis.go

Lines 33 to 38 in 6c32582

	// CheckEnvExists checks if an environment variable exists.
	// It returns the value and a boolean indicating its existence.
	func CheckEnvExists(envVar string) (string, bool) {
	value, exists := os.LookupEnv(envVar)
	return value, exists
	}

@Jeffwan What do you think?

[varungup90]

Sure, rename it to LookupEnv.

[Jeffwan]

sounds good.

[Iceber]

The failed ci is not related to the modification of this pr.

[Jeffwan]

It is a separate issue. I will take a look at the dependency, that's the object storage in volcano engine cloud

[varungup90]

Overall look good.

[Jeffwan]

it's a little bit weird that build jobs are either canceled or skipped..

[Jeffwan]

@varungup90 Did the PR pass the CI earlier or just skipped the test? the main branch test failed again.

[varungup90]

@varungup90 Did the PR pass the CI earlier or just skipped the test? the main branch test failed again.

First time when you commented on the PR for CI failures, at that time I manually restarted the failed jobs and they succeeded. When the PR was updated with method rename, all CI job succeeded so I merged (initially also failures were not related to PR). After PR merged, there were failures again that you brought to my attention.

[Jeffwan]

@varungup90 yeah, this is kind of weird, all parallel CI jobs yesterday pass and seems my current fix doesn't help as well. I tried to build locally but I can not reproduce the issue, probably due to some arch diffs. I will spend some time later on this.

If you did see they succeeded, it's probably due to other cache issues.