Bug/fix backup expiration #9227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(fixes vmware-tanzu#3555) Signed-off-by: vineetxkhurana <[email protected]>
Signed-off-by: Vaneet [email protected] Signed-off-by: vineetxkhurana <[email protected]>
docs: Explain 'N/A' EXPIRES column for new backups in get backups output Signed-off-by: Vaneet [email protected] Signed-off-by: vineetxkhurana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
This PR updates the CLI to display "N/A" for Expires when a backup is in the "New" phase and hasn't executed yet, instead of incorrectly showing a past date.
Does your change fix a particular issue?
Fixes #3555
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.