Skip to content

Bug/fix backup expiration #9227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vineetxkhurana wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bug/fix backup expiration #9227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9137fbd
fix: show 'N/A' for Expires if backup is New phase
vineetxkhurana Sep 7, 2025
95a43ff
Create 3555-vineetxkhurana
vineetxkhurana Sep 7, 2025
e710c20
Update ark_get_backups.md
vineetxkhurana Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/3555-vineetxkhurana
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CLI: Show 'N/A' for Expires column for backups in 'New' phase, instead of an incorrect past date. (#3555)
10 changes: 9 additions & 1 deletion pkg/cmd/util/output/backup_printer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,21 @@ func printBackup(backup *velerov1api.Backup) []metav1.TableRow {
status = "Deleting"
}

// Show "N/A" for expiration if backup is in New phase
var expirationDisplay string
if status == string(velerov1api.BackupPhaseNew) {
expirationDisplay = "N/A"
} else {
expirationDisplay = humanReadableTimeFromNow(expiration)
}

row.Cells = append(row.Cells,
backup.Name,
status,
backup.Status.Errors,
backup.Status.Warnings,
backup.Status.StartTimestamp,
humanReadableTimeFromNow(expiration),
expirationDisplay,
backup.Spec.StorageLocation,
metav1.FormatLabelSelector(backup.Spec.LabelSelector),
)
Expand Down
2 changes: 2 additions & 0 deletions site/content/docs/v0.5.0/cli-reference/ark_get_backups.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ ark get backups [flags]
--vmodule moduleSpec comma-separated list of pattern=N settings for file-filtered logging
```

**Note:** For backups in the "New" state (not yet executed), the EXPIRES column will display "N/A" instead of a date, indicating that the backup is not yet eligible for expiration or garbage collection.

### SEE ALSO
* [ark get](ark_get.md) - Get ark resources