Skip to content

Fix: use POSIX path separators for node-agent hostPath volumes. Fix issue #9415 #9416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mykhailo-Roit wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Fix: use POSIX path separators for node-agent hostPath volumes. Fix issue #9415 #9416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/install/daemonset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,11 @@ func DaemonSet(namespace string, opts ...podTemplateOption) *appsv1api.DaemonSet
if c.forWindows {
dsName = "node-agent-windows"
}
hostPodsVolumePath := filepath.Join(c.kubeletRootDir, "pods")
hostPluginsVolumePath := filepath.Join(c.kubeletRootDir, "plugins")
// Use forward slashes for hostPath paths to ensure POSIX-style paths in generated manifests
// even when velero CLI runs on Windows. Kubernetes hostPath.path must use '/' separator.
kubeletRoot := strings.TrimRight(c.kubeletRootDir, "/\\")
Copy link
Contributor

@Lyndon-Li Lyndon-Li Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubeletRootDir could be specified by users, so in a Windows cluster, users may specify a Windows styled path, e.g., C:\\var\\lib\\kubelet.
As a result, it ends with a path mixed with / and \\, e.g., C:\\var\\lib\\kubelet/pods.

Even though Windows supports this mix, but since you are making this change for the purpose of Use forward slashes for hostPath paths to ensure POSIX-style path in generated manifests and it looks the right way, could you consider the above case and make the entire path in POSIX style?

Copy link
Author

@Mykhailo-Roit Mykhailo-Roit Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --use-node-agent flag indicates that an agent must be deployed on the Linux cluster.

Copy link
Contributor

@Lyndon-Li Lyndon-Li Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the code here is shared by both linux cluster installation and Windows cluster installation.

hostPodsVolumePath := kubeletRoot + "/pods"
hostPluginsVolumePath := kubeletRoot + "/plugins"
volumes := []corev1api.Volume{}
volumeMounts := []corev1api.VolumeMount{}
if !c.nodeAgentDisableHostPath {
Expand Down