Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify some code #1329

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Simplify some code #1329

merged 5 commits into from
Aug 1, 2023

Conversation

davidbrochart
Copy link
Member

@davidbrochart davidbrochart commented Jun 15, 2023 •
edited
Loading

Code changes

Use partial instead of defining a function.
Remove unneeded inner_cell_generator function.

User-facing changes

None.

Backwards-incompatible changes

None.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch davidbrochart/voila/partial

martinRenou
martinRenou approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidbrochart davidbrochart changed the title Use partial Simplify some code Jun 15, 2023
martinRenou
martinRenou approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

martinRenou
martinRenou approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@davidbrochart
Copy link
Member Author

Thanks!

👍

Thanks!

👍 👍

Thanks

👍 👍 👍

@martinRenou
Copy link
Member

Is it ok to merge, or you'd like to push something else? :P

@martinRenou martinRenou merged commit f7a74cc into voila-dashboards:main Aug 1, 2023
11 of 20 checks passed
@davidbrochart davidbrochart deleted the partial branch August 1, 2023 08:38
@davidbrochart
Copy link
Member Author

Is it ok to merge, or you'd like to push something else? :P

I guess it was ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbrochart @martinRenou