remove unused feedback in test #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 12 12
Lines 483 483
Branches 43 43
=====================================
Misses 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I dont like this |
|
too late 👿 |
Talhanc
reviewed
Feb 28, 2025
Comment on lines
45
to
47
| def get_result_callback(self, future): | ||
| result = future.result().result.success | ||
| self.get_logger().info(f'Goal result: {result}') |
There was a problem hiding this comment.
Name convention is a little bit none informative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pre-commit is now a happy man o7