Skip to content

Add C++ and CMake pre-commit hooks #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

kluge7
Copy link
Contributor

@kluge7 kluge7 commented Apr 6, 2025

No description provided.

@kluge7
Copy link
Contributor Author

kluge7 commented Apr 6, 2025

Need to remove vortex-auv from here before merging: https://github.com/organizations/vortexntnu/settings/installations/57321089

@kluge7 kluge7 changed the title Add cpp and CMake pre commit hooks Add C++ and CMake pre-commit hooks Apr 6, 2025
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.61%. Comparing base (54b5a4a) to head (2008f1d).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #568   +/-   ##
=====================================
  Coverage   6.61%   6.61%           
=====================================
  Files         37      37           
  Lines       2117    2117           
  Branches      50      50           
=====================================
  Hits         140     140           
  Misses      1977    1977           
Flag Coverage Δ
unittests 6.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kluge7 kluge7 force-pushed the ci/add-cpp-pre-commit branch 3 times, most recently from 6feccc6 to f815477 Compare April 9, 2025 18:05
@kluge7
Copy link
Contributor Author

kluge7 commented Apr 9, 2025

Need to remove vortex-auv from here before merging: https://github.com/organizations/vortexntnu/settings/installations/57321089

Don't need to do this, made a separate config file for the local pre-commit hooks. To run locally:

pre-commit run --all-files -c .pre-commit-config-local.yaml

Could also be an idea to make a script which runs both

@kluge7 kluge7 force-pushed the ci/add-cpp-pre-commit branch from e44d1b0 to f394a99 Compare April 9, 2025 20:37
@kluge7 kluge7 requested a review from Copilot April 10, 2025 08:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@kluge7 kluge7 force-pushed the ci/add-cpp-pre-commit branch from 6c060f2 to afd6e40 Compare April 25, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant