Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference of how to search for the app's errors on now-defunct Splunk #544

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Remove reference of how to search for the app's errors on now-defunct Splunk #544

merged 5 commits into from
Sep 20, 2023

Conversation

filipewl
Copy link
Contributor

@filipewl filipewl commented Sep 19, 2023 •
edited
Loading

What is the purpose of this pull request?

Since we're no longer using Splunk. There's also the case that we were logging this message to users without access to the logging service, which wasn't helpful.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@filipewl filipewl self-assigned this Sep 19, 2023
@filipewl filipewl marked this pull request as ready for review September 19, 2023 17:59
@filipewl filipewl changed the title Replace Splunk query reference with Lucene's, which is compatible to OS Replace Splunk app error's query with a valid OpenSearch's Sep 19, 2023
@filipewl filipewl changed the title Replace Splunk app error's query with a valid OpenSearch's Remove reference of how to search for the app's errors on now-defunct Splunk Sep 19, 2023
@filipewl filipewl merged commit 566900b into master Sep 20, 2023
3 checks passed
@filipewl filipewl deleted the chore/remove-splunk-log branch September 20, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturpimentel arturpimentel arturpimentel approved these changes

Assignees

@filipewl filipewl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipewl @arturpimentel