Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference of how to search for the app's errors on now-defunct Splunk #544

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Remove reference of how to search for the app's errors on now-defunct Splunk #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b56962
Replace Splunk query reference with Lucene's, which is compatible to OS
filipewl Sep 19, 2023
683a1d4
Log only if the app isn't 3P as user won't likely have access to OS
filipewl Sep 19, 2023
84de6b8
Remove log altogether since it's something that should be known by us
filipewl Sep 19, 2023
62004a7
Merge branch 'master' into chore/remove-splunk-log
filipewl Sep 20, 2023
c94a0ba
Release v6.45.22
filipewl Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [6.45.22] - 2023-09-20

### Removed

- Remove reference of how to search for the app's errors on now-defunct Splunk.

### Fixed

- Error tracing spans not logging the details.
Expand Down Expand Up @@ -1793,11 +1799,12 @@ instead
- `HttpClient` now adds `'Accept-Encoding': 'gzip'` header by default.


[Unreleased]: https://github.com/vtex/node-vtex-api/compare/v6.45.21...HEAD
[Unreleased]: https://github.com/vtex/node-vtex-api/compare/v6.45.22...HEAD
[6.45.15]: https://github.com/vtex/node-vtex-api/compare/v6.45.14...v6.45.15
[6.45.14]: https://github.com/vtex/node-vtex-api/compare/v6.45.13...v6.45.14
[6.45.13]: https://github.com/vtex/node-vtex-api/compare/v6.45.12...v6.45.13

[6.45.22]: https://github.com/vtex/node-vtex-api/compare/v6.45.21...v6.45.22
[6.45.21]: https://github.com/vtex/node-vtex-api/compare/v6.45.21-beta.2...v6.45.21
[6.45.21-beta.2]: https://github.com/vtex/node-vtex-api/compare/v6.45.21-beta.1...v6.45.21-beta.2
[6.45.21-beta.1]: https://github.com/vtex/node-vtex-api/compare/v6.45.21-beta.0...v6.45.21-beta.1
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vtex/api",
"version": "6.45.21",
"version": "6.45.22",
"description": "VTEX I/O API client",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
Expand Down
15 changes: 0 additions & 15 deletions src/service/logger/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,20 +92,5 @@ export class Logger {
}

console.log(JSON.stringify(inflatedLog))

// Warn the developer how to retrieve the error in splunk
this.logSplunkQuery()
}

/**
* Logs splunk query so the developer can search for the errors in splunk.
* This function runs only once in the lifetime of the Logger class so we
* don't mess up with the developer's terminal
*/
private logSplunkQuery = () => {
if (linked) {
const message = `Try this query at Splunk to retrieve error log: 'index=io_vtex_logs app="${app}" account=${this.account} workspace=${this.workspace} level=error OR level=warn'`
logOnceToDevConsole(message, LogLevel.Info)
}
}
}
Loading