Add confirmation page for deleting A/B tests associated with a page

[joelwilliam2005]

Fixes issue #90
By adding new Confirmation page for deleting A/B tests associated with a page.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (1ecc8d8) to head (19b1460).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   93.51%   93.78%   +0.26%     
==========================================
  Files          42       43       +1     
  Lines        1620     1690      +70     
  Branches      107      111       +4     
==========================================
+ Hits         1515     1585      +70     
  Misses         69       69              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mgax]

Hi @joelwilliam2005, thanks for fixing this issue, and taking the time to make a PR! 🙌

I've tested the branch locally and it does what it says. The UI is nice and slick!

However, it does not address deleting pages from their parent page listing (which is what I tried initially, when the AB test was still active, since I did not have access to its individual delete button). Since that is a bulk delete action, I'm not sure what to do about it.

[joelwilliam2005]

Hi @joelwilliam2005, thanks for fixing this issue, and taking the time to make a PR! 🙌

I've tested the branch locally and it does what it says. The UI is nice and slick!

However, it does not address deleting pages from their parent page listing (which is what I tried initially, when the AB test was still active, since I did not have access to its individual delete button). Since that is a bulk delete action, I'm not sure what to do about it.

@mgax I have fixed the addressed issues.
And yes this does not address deleting pages using bulk deletion, it works for deleting individual pages.
Perhaps I can fix that in another PR, that addresses bulk deletion which would require a new page that lists the pages that have A/B tests.

[mgax]

Lots of good stuff in here, nice work @joelwilliam2005! I've left some suggestions, hopefully I'm not overwhelming you with change requests 😅

Sorry about the code style nitpicks; ideally we should have automated linting in place to catch them. I've opened a ticket for this: #95.

[joelwilliam2005]

Thank you for reviewing @mgax
I'll look into your suggested changes.

[mgax]

Hi @joelwilliam2005, thanks for addressing the comments! The PR is in pretty good shape I think. There are a couple of issues left to address. Cheers!

[mgax]

Sorry, I've pushed an erroneous commit to your branch, I've now removed it.

[mgax]

@joelwilliam2005 nice work, thank you! 🎉

[Stormheg]

@joelwilliam2005 @mgax wanted to let you know that I just released v0.12 with this confirmation screen included 🎉

Thank you both for your work on this!