Add confirmation page for deleting A/B tests associated with a page

wagtail_ab_testing/test/tests/test_delete_abtest.py

@@ -4,7 +4,7 @@
 from django.contrib.contenttypes.models import ContentType
 from django.test import RequestFactory, TestCase
 from django.urls import reverse
-from wagtail.models import Page
+from wagtail.models import GroupPagePermission, Page
 from wagtail.test.utils import WagtailTestUtils
 
 from wagtail_ab_testing.models import AbTest
@@ -22,10 +22,6 @@ def setUp(self):
         ):
             self.moderators_group.permissions.add(permission)
 
-        for permission in Permission.objects.filter(
-            content_type=ContentType.objects.get_for_model(Page)
-        ):
-            self.moderators_group.permissions.add(permission)
         self.user.is_superuser = False
         self.user.groups.add(self.moderators_group)
         self.user.save()
@@ -53,7 +49,7 @@ def test_check_ab_tests_hook_with_tests(self):
 
         self.assertRedirects(
             response,
-            reverse("wagtail_ab_testing:ab_test_delete", args=[self.page.id]),
+            reverse("wagtail_ab_testing_admin:ab_test_delete", args=[self.page.id]),
             msg_prefix="Redirection to the delete A/B tests confirmation page failed.",
         )
 
@@ -71,7 +67,7 @@ def test_ab_test_delete_view(self):
         self.assertTemplateUsed(response, "wagtail_ab_testing/delete_ab_tests.html")
 
         response = self.client.post(
-            reverse("wagtail_ab_testing:ab_test_delete", args=[self.page.id])
+            reverse("wagtail_ab_testing_admin:ab_test_delete", args=[self.page.id])
         )
 
         self.assertEqual(AbTest.objects.filter(page=self.page).count(), 0)
@@ -88,30 +84,46 @@ def test_ab_test_delete_view_without_delete_abtest_permission(self):
         self.user.save()
 
         response = self.client.get(
-            reverse("wagtail_ab_testing:ab_test_delete", args=[self.page.id])
+            reverse("wagtail_ab_testing_admin:ab_test_delete", args=[self.page.id])
         )
 
-        self.assertEqual(response.status_code, 403)
+        self.assertRedirects(response, reverse("wagtailadmin_home"))
+        self.assertEqual(
+            response.context["message"],
+            "Sorry, you do not have permission to access this area.",
+        )
 
         response = self.client.post(
-            reverse("wagtail_ab_testing:ab_test_delete", args=[self.page.id])
+            reverse("wagtail_ab_testing_admin:ab_test_delete", args=[self.page.id])
         )
 
-        self.assertEqual(response.status_code, 403)
+        self.assertRedirects(response, reverse("wagtailadmin_home"))
+        self.assertEqual(
+            response.context["message"],
+            "Sorry, you do not have permission to access this area.",
+        )
 
     def test_ab_test_delete_view_without_delete_page_permission(self):
-        delete_page_permission = Permission.objects.get(codename="delete_page")
-        self.moderators_group.permissions.remove(delete_page_permission)
-        self.user.save()
+        GroupPagePermission.objects.filter(
+            group=self.moderators_group, permission__codename="change_page"
+        ).delete()
 
         response = self.client.get(
-            reverse("wagtail_ab_testing:ab_test_delete", args=[self.page.id])
+            reverse("wagtail_ab_testing_admin:ab_test_delete", args=[self.page.id])
         )
 
-        self.assertEqual(response.status_code, 403)
+        self.assertRedirects(response, reverse("wagtailadmin_home"))
+        self.assertEqual(
+            response.context["message"],
+            "Sorry, you do not have permission to access this area.",
+        )
 
         response = self.client.post(
-            reverse("wagtail_ab_testing:ab_test_delete", args=[self.page.id])
+            reverse("wagtail_ab_testing_admin:ab_test_delete", args=[self.page.id])
         )
 
-        self.assertEqual(response.status_code, 403)
+        self.assertRedirects(response, reverse("wagtailadmin_home"))
+        self.assertEqual(
+            response.context["message"],
+            "Sorry, you do not have permission to access this area.",
+        )

wagtail_ab_testing/urls.py

@@ -8,9 +8,4 @@
         "register-participant/", views.register_participant, name="register_participant"
     ),
     path("goal-reached/", views.goal_reached, name="goal_reached"),
-    path(
-        "pages/<int:page_id>/delete/abtests/",
-        views.ab_test_delete,
-        name="ab_test_delete",
-    ),
 ]

wagtail_ab_testing/views.py

@@ -720,9 +720,10 @@ def ab_test_delete(request, page_id):
     page = get_object_or_404(Page, id=page_id)
     ab_tests = page.ab_tests.order_by("-first_started_at")
 
-    if not request.user.has_perm(
-        "wagtailcore.delete_page"
-    ) or not request.user.has_perm("wagtail_ab_testing.delete_abtest"):
+    if not (
+        page.permissions_for_user(request.user).can_delete()
+        and request.user.has_perm("wagtail_ab_testing.delete_abtest")
+    ):
         raise PermissionDenied
 
     if request.method == "POST":

wagtail_ab_testing/wagtail_hooks.py

@@ -247,7 +247,9 @@ def register_add_abtest_permission():
 def check_ab_tests_for_page(request, page):
     if page.ab_tests.exists():
         return HttpResponseRedirect(
-            reverse("wagtail_ab_testing:ab_test_delete", kwargs={"page_id": page.id})
+            reverse(
+                "wagtail_ab_testing_admin:ab_test_delete", kwargs={"page_id": page.id}
+            )
         )
 
     return None