-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[v3] Ensure the window name is passed as header to AssetFileServer #4687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3-alpha
Are you sure you want to change the base?
Conversation
WalkthroughAdded the window name to request headers in the webViewAssetRequest to enable logging with the window ID. This includes a corresponding changelog entry documenting the fix. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a213fbb to
b47e965
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|



Description
Adds header
x-wails-window-nameto asset server requests, so that they can be logged.https://github.com/jasikpark/wails/blob/eb3a7e53925d9c755afc312f1579219f8497d61f/v3/internal/assetserver/assetserver.go#L72-L80
Type of change
Please select the option that is relevant.
How Has This Been Tested?
I haven't tested this, but it should be possible to test by running a wails app and loading a webview window, and looking in the logs for logs like:
where instead, the log contains the window name:
If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.macOS 26.1
Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit