Skip to content

[v3] Ensure the window name is passed as header to AssetFileServer #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v3-alpha
Choose a base branch
from
Open

[v3] Ensure the window name is passed as header to AssetFileServer #4687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8b5a2d
Add window name header when making webview requests
jasikpark Nov 4, 2025
ec1b152
Add changelog item
jasikpark Nov 5, 2025
b47e965
Update PR no in changelog entry
jasikpark Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion v3/UNRELEASED_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Unreleased Changes

<!--
<!--
This file is used to collect changelog entries for the next v3-alpha release.
Add your changes under the appropriate sections below.

Expand All @@ -23,6 +23,7 @@ After processing, the content will be moved to the main changelog and this file

## Fixed
<!-- Bug fixes -->
- Added missing window name to request headers, so it can be logged with the window ID by @jasikpark in [#4687](https://github.com/wailsapp/wails/pull/4687)

## Deprecated
<!-- Soon-to-be removed features -->
Expand Down
1 change: 1 addition & 0 deletions v3/pkg/application/application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ func (r *webViewAssetRequest) Header() (http.Header, error) {

hh := h.Clone()
hh.Set(webViewRequestHeaderWindowId, strconv.FormatUint(uint64(r.windowId), 10))
hh.Set(webViewRequestHeaderWindowName, r.windowName)
return hh, nil
}

Expand Down