Skip to content

Conversation

@fryorcraken
Copy link
Collaborator

@fryorcraken fryorcraken commented Nov 13, 2025

Now that the global state is not polluted any more.

Fixes #2648 (maybe)

Problem / Description

A test was breaking setInterval and setTimeout: #2729 (comment) and is now skipped.

Solution

Tests can be re-enabled.

Notes

Did several test runs to confirm

  1. https://github.com/waku-org/js-waku/actions/runs/19478876154/job/55745598023?pr=2734: pass

Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@fryorcraken fryorcraken changed the title test: unskip tests test: re-enable sds tests Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 96.31 KB (0%) 2 s (0%) 453 ms (+4.3% 🔺) 2.4 s
Waku Simple Light Node 147.49 KB (0%) 3 s (0%) 601 ms (+42.57% 🔺) 3.6 s
ECIES encryption 22.62 KB (0%) 453 ms (0%) 363 ms (+364.96% 🔺) 815 ms
Symmetric encryption 22 KB (0%) 440 ms (0%) 104 ms (-48.07% 🔽) 544 ms
DNS discovery 52.17 KB (0%) 1.1 s (0%) 590 ms (+129.75% 🔺) 1.7 s
Peer Exchange discovery 52.91 KB (0%) 1.1 s (0%) 369 ms (+43.08% 🔺) 1.5 s
Peer Cache Discovery 46.64 KB (0%) 933 ms (0%) 334 ms (+52.61% 🔺) 1.3 s
Privacy preserving protocols 77.28 KB (0%) 1.6 s (0%) 595 ms (+30.34% 🔺) 2.2 s
Waku Filter 79.72 KB (0%) 1.6 s (0%) 345 ms (-9.25% 🔽) 2 s
Waku LightPush 77.99 KB (0%) 1.6 s (0%) 449 ms (+25.36% 🔺) 2.1 s
History retrieval protocols 83.65 KB (0%) 1.7 s (0%) 479 ms (+107.56% 🔺) 2.2 s
Deterministic Message Hashing 28.98 KB (0%) 580 ms (0%) 202 ms (+33.89% 🔺) 781 ms

@fryorcraken fryorcraken force-pushed the reliable-channels/sync-state branch 2 times, most recently from a6323d8 to 4dde565 Compare November 13, 2025 05:39
Base automatically changed from reliable-channels/sync-state to master November 15, 2025 21:57
Now that the global state is not polluted anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(sds): sds tests are failing

2 participants