Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade nwake image from v0.25.0 to latest-release #95

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

darshankabariya
Copy link

No description provided.

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to set it to the latest release (0.28.0 in this case) instead of the latest image, which might be unstable.

Maybe we can create a latest-release tag in our docker registry so we don't have to manually change things every release?

@darshankabariya darshankabariya changed the title fix: upgrade nwake image from v0.25.0 to latest fix: upgrade nwake image from v0.25.0 to latest-release May 27, 2024
@Ivansete-status
Copy link
Contributor

Ivansete-status commented May 27, 2024

Thanks for that @DarshanBPatel !
I think you can either apply that change or just fix it to v0.28.0, as @gabrielmer mentioned.
On the other hand, I think is interesting to use the latest-release in the following:

image: ${NWAKU_IMAGE:-harbor.status.im/wakuorg/nwaku:v0.28.0}

⚠️ Notice that we cannot merge this until we generate a nwaku latest-release.

@Ivansete-status
Copy link
Contributor

@darshankabariya - this PR seems not to be needed now as we are heading v0.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants