feat: Adding support for k8s webhooks secret store #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyblasczyk
requested review from
gls4,
jsbroks,
nfoucha and
vanpelt
as code owners
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
gls4
reviewed
Oct 3, 2023
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
jsbroks
requested changes
Oct 10, 2023
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
jsbroks
reviewed
Oct 17, 2023
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
zacharyblasczyk
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
jsbroks
approved these changes
Oct 23, 2023
|
feat: Update wandb Helm Chart to support kubernetes secret store |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a role and role binding to the existing wandb Service Account.
One thing that needs to be determined is if we want these to be optional as the existing Service Account Implementation is optional.