Skip to content

feat: Adding support for k8s webhooks secret store #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 23, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
*.tgz
.vscode/
dryrun.yaml
license.txt
test-values.yaml
4 changes: 2 additions & 2 deletions charts/wandb/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.2.3
appVersion: "0.42.0"
version: 0.3.0
appVersion: "0.44.0"
icon: https://wandb.ai/logo.svg
maintainers:
- name: wandb
Expand Down
15 changes: 15 additions & 0 deletions charts/wandb/templates/role.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: secret-manager-role
labels:
{{- include "wandb.labels" . | nindent 4 }}
rules:
- apiGroups: [""]
resources: ["secrets"]
verbs: ["get", "create", "update", "delete"]
- apiGroups: [""]
resources: ["namespaces"]
verbs: ["get"]
...
15 changes: 15 additions & 0 deletions charts/wandb/templates/rolebinding.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: wandb-secret-manager-binding
labels:
{{- include "wandb.labels" . | nindent 4 }}
subjects:
- kind: ServiceAccount
name: {{ include "wandb.serviceAccountName" . }}
roleRef:
kind: Role
name: secret-manager-role
apiGroup: rbac.authorization.k8s.io
...