-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Adding support for k8s webhooks secret store #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
22decaf
Bump operator memory limit
zacharyblasczyk 4b74bb2
feat: Adding support for k8s webhooks secret store
zacharyblasczyk 75e787d
Merge branch 'main' into zacharyb/secrets-store
zacharyblasczyk 3747ba2
feat: Update role to check if NS exsists
zacharyblasczyk a65283d
feat: Bump the appVersion to 0.44.0
zacharyblasczyk 7f42f53
Merge remote-tracking branch 'origin/main' into zacharyb/secrets-store
zacharyblasczyk 39959cf
fix: Testing with 0.44.1
zacharyblasczyk 63d0fe0
Update role.yaml
zacharyblasczyk 9a2b8ac
Update rolebinding.yaml
zacharyblasczyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
*.tgz | ||
.vscode/ | ||
dryrun.yaml | ||
license.txt | ||
test-values.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: Role | ||
metadata: | ||
name: secret-manager-role | ||
zacharyblasczyk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
labels: | ||
{{- include "wandb.labels" . | nindent 4 }} | ||
rules: | ||
- apiGroups: [""] | ||
resources: ["secrets"] | ||
verbs: ["get", "create", "update", "delete"] | ||
- apiGroups: [""] | ||
resources: ["namespaces"] | ||
verbs: ["get"] | ||
zacharyblasczyk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: RoleBinding | ||
metadata: | ||
name: wandb-secret-manager-binding | ||
labels: | ||
{{- include "wandb.labels" . | nindent 4 }} | ||
subjects: | ||
- kind: ServiceAccount | ||
name: {{ include "wandb.serviceAccountName" . }} | ||
roleRef: | ||
kind: Role | ||
name: secret-manager-role | ||
apiGroup: rbac.authorization.k8s.io | ||
... | ||
zacharyblasczyk marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.