Handle agent centralized configuration commands #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr0me
force-pushed
the
enhancement/32-agent-centralized-configuration-class-mvp
branch
from
64cea84
to
0d51b92
Compare
3 tasks
jr0me
force-pushed
the
enhancement/32-agent-centralized-configuration-class-mvp
branch
from
0d51b92
to
64a6b96
Compare
Nicogp
approved these changes
Oct 18, 2024
sdvendramini
approved these changes
Oct 18, 2024
At the moment just Start, Stop and Name. This class will not be performing any specific actions on start and stop, at least for this PR.
jr0me
force-pushed
the
enhancement/32-agent-centralized-configuration-class-mvp
branch
from
9b4a2bb
to
9530c70
Compare
It's not necessary to set any configuration at the moment
They are included and used in its public header
It's currently a placeholder for the future implementation
This commit adds a new method, SetGroupIdFunction, to the CentralizedConfiguration class. This method allows the user to set a function that takes a vector of integers as input and returns a boolean value. The function is used to set the group ID in the CentralizedConfiguration module. If the function returns true, the group ID is set successfully, otherwise, it returns a failure status. The SetGroupIdFunction method is implemented in the CentralizedConfiguration class and takes a std::function object as input. This function can be used to perform custom logic for setting the group ID. This commit also includes a test case which verifies that the SetGroupIdFunction method is called and returns the correct result.
This function is used for the update-group command, which will fetch the groups the agent belongs to, download their configuration files, and apply them.
The ModuleManager imposes this requirement, although it doesn't need it.
…d download configuration files for them
jr0me
force-pushed
the
enhancement/32-agent-centralized-configuration-class-mvp
branch
from
9530c70
to
9e3bc20
Compare
cborla
reviewed
Oct 18, 2024
cborla
deleted the
enhancement/32-agent-centralized-configuration-class-mvp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a CentralizedConfiguration class that will handle the incoming
set-groupandupdate-groupcommands.Tests