Skip to content

refactor: remove module graph param of export info setters #10507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented May 29, 2025

Summary

Just remove module graph param of export info setters to not send the whole module graph everywhere

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 29, 2025
Copy link
Contributor Author

LingyuCoder commented May 29, 2025

Base automatically changed from refactor/move-export-info-code to main May 29, 2025 03:49
Copy link

codspeed-hq bot commented May 29, 2025

CodSpeed Performance Report

Merging #10507 will not alter performance

Comparing refactor/export-info-setter (0f59c5d) with main (2abe6c3)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 12 untouched benchmarks

@LingyuCoder LingyuCoder force-pushed the refactor/export-info-setter branch from 0680ccf to 0f59c5d Compare May 29, 2025 04:09
Copy link

netlify bot commented May 29, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 0f59c5d
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6837dde14f21e800082c2a31

@LingyuCoder LingyuCoder changed the title refactor: remove module graph of export_info setters refactor: remove module graph param of export_info setters May 29, 2025
@LingyuCoder LingyuCoder changed the title refactor: remove module graph param of export_info setters refactor: remove module graph param of export info setters May 29, 2025
@LingyuCoder LingyuCoder requested a review from JSerFeng May 29, 2025 07:34
@LingyuCoder LingyuCoder marked this pull request as ready for review May 29, 2025 07:35
@LingyuCoder LingyuCoder merged commit c957e2c into main May 29, 2025
42 checks passed
@LingyuCoder LingyuCoder deleted the refactor/export-info-setter branch May 29, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants