Skip to content

refactor: remove module graph of export_info getters #10510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 3, 2025

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented May 29, 2025

Summary

Remove module graph param of getters of export info to make sure the module graph is not sent everywhere

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 29, 2025
Copy link
Contributor Author

LingyuCoder commented May 29, 2025

Copy link

codspeed-hq bot commented May 29, 2025

CodSpeed Performance Report

Merging #10510 will not alter performance

Comparing refactor/export-info-getter (35eda7e) with main (c957e2c)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 12 untouched benchmarks

Copy link
Contributor

github-actions bot commented May 29, 2025

📝 Benchmark detail: Open

Name Base (2025-05-29 35f1126) Current Change
10000_big_production-mode_disable-minimize + exec 35.4 s ± 557 ms 36.5 s ± 298 ms +3.32 %
10000_development-mode + exec 1.89 s ± 21 ms 1.83 s ± 125 ms -3.41 %
10000_development-mode_hmr + exec 748 ms ± 21 ms 745 ms ± 24 ms -0.42 %
10000_production-mode + exec 2.32 s ± 114 ms 2.25 s ± 41 ms -3.01 %
10000_production-mode_persistent-cold + exec 2.49 s ± 39 ms 2.43 s ± 15 ms -2.52 %
10000_production-mode_persistent-hot + exec 1.73 s ± 21 ms 1.7 s ± 28 ms -1.76 %
arco-pro_development-mode + exec 1.8 s ± 61 ms 1.78 s ± 110 ms -0.83 %
arco-pro_development-mode_hmr + exec 383 ms ± 1.2 ms 382 ms ± 0.74 ms -0.18 %
arco-pro_production-mode + exec 3.4 s ± 88 ms 3.46 s ± 86 ms +1.83 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.47 s ± 69 ms 3.61 s ± 79 ms +3.90 %
arco-pro_production-mode_persistent-cold + exec 3.51 s ± 147 ms 3.54 s ± 56 ms +0.70 %
arco-pro_production-mode_persistent-hot + exec 2.15 s ± 63 ms 2.19 s ± 227 ms +1.68 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.43 s ± 130 ms 3.49 s ± 90 ms +1.67 %
large-dyn-imports_development-mode + exec 2.12 s ± 71 ms 2.04 s ± 81 ms -3.39 %
large-dyn-imports_production-mode + exec 2.07 s ± 20 ms 2.06 s ± 37 ms -0.91 %
threejs_development-mode_10x + exec 1.67 s ± 27 ms 1.63 s ± 16 ms -2.39 %
threejs_development-mode_10x_hmr + exec 870 ms ± 23 ms 845 ms ± 12 ms -2.85 %
threejs_production-mode_10x + exec 5.16 s ± 60 ms 5.19 s ± 254 ms +0.56 %
threejs_production-mode_10x_persistent-cold + exec 5.25 s ± 156 ms 5.29 s ± 393 ms +0.77 %
threejs_production-mode_10x_persistent-hot + exec 4.46 s ± 327 ms 4.42 s ± 313 ms -0.85 %
10000_big_production-mode_disable-minimize + rss memory 9242 MiB ± 79.4 MiB 9121 MiB ± 72 MiB -1.30 %
10000_development-mode + rss memory 642 MiB ± 14.1 MiB 675 MiB ± 18.9 MiB +5.11 %
10000_development-mode_hmr + rss memory 789 MiB ± 17 MiB 797 MiB ± 17.8 MiB +1.03 %
10000_production-mode + rss memory 663 MiB ± 41.7 MiB 684 MiB ± 16.5 MiB +3.10 %
10000_production-mode_persistent-cold + rss memory 763 MiB ± 43.3 MiB 814 MiB ± 22.6 MiB +6.63 %
10000_production-mode_persistent-hot + rss memory 770 MiB ± 51.6 MiB 748 MiB ± 23.8 MiB -2.84 %
arco-pro_development-mode + rss memory 576 MiB ± 69.5 MiB 594 MiB ± 41.5 MiB +3.12 %
arco-pro_development-mode_hmr + rss memory 483 MiB ± 43.1 MiB 507 MiB ± 38.2 MiB +5.14 %
arco-pro_production-mode + rss memory 688 MiB ± 81 MiB 732 MiB ± 46.8 MiB +6.48 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 706 MiB ± 33.3 MiB 747 MiB ± 66.8 MiB +5.77 %
arco-pro_production-mode_persistent-cold + rss memory 794 MiB ± 104 MiB 789 MiB ± 49.8 MiB -0.57 %
arco-pro_production-mode_persistent-hot + rss memory 662 MiB ± 63.2 MiB 676 MiB ± 90.8 MiB +2.02 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 705 MiB ± 114 MiB 696 MiB ± 75.3 MiB -1.25 %
large-dyn-imports_development-mode + rss memory 662 MiB ± 5.87 MiB 683 MiB ± 20.8 MiB +3.26 %
large-dyn-imports_production-mode + rss memory 548 MiB ± 6.32 MiB 567 MiB ± 11.9 MiB +3.55 %
threejs_development-mode_10x + rss memory 614 MiB ± 16.3 MiB 623 MiB ± 17.9 MiB +1.57 %
threejs_development-mode_10x_hmr + rss memory 745 MiB ± 23.2 MiB 751 MiB ± 34.5 MiB +0.75 %
threejs_production-mode_10x + rss memory 881 MiB ± 34.2 MiB 911 MiB ± 30.2 MiB +3.33 %
threejs_production-mode_10x_persistent-cold + rss memory 974 MiB ± 31.1 MiB 981 MiB ± 45.1 MiB +0.71 %
threejs_production-mode_10x_persistent-hot + rss memory 851 MiB ± 35.8 MiB 854 MiB ± 30.6 MiB +0.38 %

Base automatically changed from refactor/export-info-setter to main May 29, 2025 09:35
@LingyuCoder LingyuCoder force-pushed the refactor/export-info-getter branch from fbc1d81 to 35eda7e Compare May 29, 2025 09:40
Copy link

netlify bot commented May 29, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 35eda7e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68382b98f5f5890008d7d11b

@web-infra-dev web-infra-dev deleted a comment from github-actions bot May 29, 2025
@web-infra-dev web-infra-dev deleted a comment from github-actions bot May 29, 2025
@LingyuCoder LingyuCoder marked this pull request as ready for review May 30, 2025 10:23
@LingyuCoder LingyuCoder requested a review from JSerFeng May 30, 2025 10:23
@LingyuCoder LingyuCoder enabled auto-merge (squash) May 30, 2025 10:24
@LingyuCoder LingyuCoder merged commit 2185b2b into main Jun 3, 2025
36 checks passed
@LingyuCoder LingyuCoder deleted the refactor/export-info-getter branch June 3, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants