Skip to content

Conversation

@gameroman
Copy link
Contributor

Closes #1446

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/knip@1447

commit: e64ed52

@webpro
Copy link
Member

webpro commented Jan 6, 2026

Thanks for bringing this up again, and the efforts already put in. I'm going to change the title to make it clear that we should really only merge if we can get this right.

@webpro webpro changed the title Replace fast-glob with tinyglobby where possible Replace fast-glob with tinyglobby Jan 6, 2026
@gameroman
Copy link
Contributor Author

gameroman commented Jan 6, 2026

looks like there are 4 places where the firstGlob function is used

const isEnabled: IsPluginEnabled = async ({ cwd }) => Boolean(await _firstGlob({ cwd, patterns: ['yarn.lock'] }));

return Boolean(await _firstGlob({ cwd, patterns: defaultConfigPatterns }));

Boolean(await _firstGlob({ cwd, patterns: ['.github/workflows/*.{yml,yaml}'] }));

(await _firstGlob({ cwd, patterns: ['pnpm-lock.yaml', 'pnpm-workspace.yaml'] }))

@gameroman
Copy link
Contributor Author

@webpro I removed 2 of the usages and will see if I can deal with the other 2

@gameroman
Copy link
Contributor Author

removed another one

@gameroman
Copy link
Contributor Author

removed the last one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧩 Replace fast-glob with tinyglobby

2 participants