-
Notifications
You must be signed in to change notification settings - Fork 41
chore(logging): guarantee app metadata in log files [WPB-8645] #3902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(logging): guarantee app metadata in log files [WPB-8645] #3902
Conversation
Updated `start` in `LogFileWriter` to suspend until log initialization is complete, ensuring logging consistency. Added coroutine synchronization using `Job` and adjusted the usage in `UserDebugViewModel` accordingly.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3902 +/- ##
=====================================================
- Coverage 45.69% 45.67% -0.02%
=====================================================
Files 473 473
Lines 16126 16131 +5
Branches 2725 2725
=====================================================
Hits 7368 7368
- Misses 7991 7996 +5
Partials 767 767
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Built wire-android-staging-compat-pr-3902.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Most of the times, we don't get basic app information when reading the log files.
Causes
We launch an async coroutine that will initialise the
LogFileWriter
, and immediately log basic app information, like App version, OS version, Phone model, Commit hash, etc.Solutions
Make it so that
LogFileWriter.start()
suspends until it actually starts. Then we can start printing basic information.This is done by waiting for the first log lines to come before completing the
LogFileWriter.start
.PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.