Skip to content

fix: make sure coroutine is init before using it on analytics manager [WPB-17078] #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Apr 8, 2025

BugWPB-17078 [Android] play store crash related to countly


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

It seems there is a case where we are trying to access the coroutine scope and this is not init.

Causes (Optional)

Edge case of init not being called ?

Solutions

Just check for the coroutine to be init before accessing it.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Built wire-android-staging-compat-pr-3977.apk is available for download

Copy link

sonarqubecloud bot commented Apr 9, 2025

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Built wire-android-staging-compat-pr-3977.apk is available for download

@MohamadJaara MohamadJaara changed the title fix: make sure coroutine is init before using it on analytics manager fix: make sure coroutine is init before using it on analytics manager [WPB-17078] Apr 9, 2025
@MohamadJaara MohamadJaara enabled auto-merge April 9, 2025 11:06
@MohamadJaara MohamadJaara added this pull request to the merge queue Apr 9, 2025
Merged via the queue into release/candidate with commit 00c3613 Apr 9, 2025
15 of 17 checks passed
@MohamadJaara MohamadJaara deleted the fix/analytics-scopecortouine-check branch April 9, 2025 11:31
github-actions bot pushed a commit that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants