Skip to content

Add flag to control whether applying Aztec styles to HTML #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Nov 22, 2021

This PR introduces a new resource bool (use_aztec_style_html) as a flag to control whether, when parsing HTML, it should apply Aztec styles (reference). This change shouldn't produce regressions as the flag by default is set to true, which is the default behavior.

Related to wordpress-mobile/gutenberg-mobile#3136.

Test

Verify that no regressions are introduced

  1. Open the demo app.
  2. Observe that the content is properly rendered with expected styles.

Review

[TBD]

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@fluiddot fluiddot added the Gutenberg This issue is also valid importing Aztec in Gutenberg label Nov 22, 2021
@fluiddot fluiddot self-assigned this Nov 22, 2021
@fluiddot fluiddot changed the title Add flag flag to control whether applying Aztec styles to HTML Add flag to control whether applying Aztec styles to HTML Nov 22, 2021
@fluiddot fluiddot marked this pull request as ready for review November 23, 2021 11:42
@fluiddot
Copy link
Contributor Author

This change is no longer required after #945 being merged.

@fluiddot fluiddot closed this Nov 25, 2021
@fluiddot fluiddot deleted the add/aztec-style-html-bool branch November 25, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg This issue is also valid importing Aztec in Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant