Preserve link, code span instances when styling #945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
PR to preserve the span and tag order for
link
andcode
tags. Although HTML doesn't dictate that the inline element order is of importance, there's no good reason for Aztec to alter the order when parsing.In this PR, the code that applies style to the
a
andcode
spans is refactored to be able to set the style on the span without replace the span itself in the spannable.This PR is an alternative approach of #944.
Test
MainActivity.kt
use the following html as value to the EXAMPLE val:<p>This is a <a href="http://wordpress.com"><strong>link</strong></a></p>
EXAMPLE
strong
is still nested inside thea
The above steps fail without the changes in this PR.
Make sure strings will be translated:
strings.xml
as a part of the integration PR.