Support residentIDP #7507
Support residentIDP #7507
Conversation
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
| private boolean isUseEntityIDAsIssuerEnabled() { | ||
|
|
||
| return Boolean.parseBoolean(IdentityUtil.getProperty(USE_ENTITY_ID_AS_ISSUER)); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
| private boolean isUseEntityIDAsIssuerEnabled() { | |
| return Boolean.parseBoolean(IdentityUtil.getProperty(USE_ENTITY_ID_AS_ISSUER)); | |
| private boolean isUseEntityIDAsIssuerEnabled() { | |
| boolean useEntityIdAsIssuer = Boolean.parseBoolean(IdentityUtil.getProperty(USE_ENTITY_ID_AS_ISSUER)); | |
| if (log.isDebugEnabled()) { | |
| log.debug("UseEntityIdAsIssuer configuration value: " + useEntityIdAsIssuer); | |
| } | |
| return useEntityIdAsIssuer; |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 2 |
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces support for configuring the ResidentIDP entity ID and using it as an issuer in OpenID Connect authentication. The changes enable the system to use a configured entity ID as the issuer when tenant-qualified URLs are enabled, providing more flexibility in identity provider configuration.
| // Check whether config is enabled to configure Entity ID in Resident IDP | ||
| private boolean isUseEntityIDAsIssuerEnabled() { | ||
|
|
||
| return Boolean.parseBoolean(IdentityUtil.getProperty(USE_ENTITY_ID_AS_ISSUER)); | ||
| } |
There was a problem hiding this comment.
Method isUseEntityIDAsIssuerEnabled() is missing a docstring. All public methods should have a docstring.
| OPENID_IDP_ENTITY_ID); | ||
| if (isUseEntityIDAsIssuerEnabled()) { | ||
| if (log.isDebugEnabled()) { | ||
| log.debug("Using the configured entity ID as the issuer in the " + tenantDomain+ " tenant."); |
There was a problem hiding this comment.
String concatenation in log statement should be wrapped with if (log.isDebugEnabled()) check to avoid unnecessary computation. While the debug check exists, the string concatenation happens outside of it during method parameter evaluation.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #7507 +/- ##
============================================
+ Coverage 50.59% 50.88% +0.28%
+ Complexity 19117 18989 -128
============================================
Files 2094 2099 +5
Lines 122521 121754 -767
Branches 25450 25218 -232
============================================
- Hits 61987 61951 -36
+ Misses 52582 51802 -780
- Partials 7952 8001 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/18370819340
|
2 participants
Proposed changes in this pull request
Bringing back support to configure ResidentIDP entity ID and ability to use it as issuer.
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Developer Checklist (Mandatory)
product-isissue to track any behavioral change or migration impact.Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation