Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(example): enhance example for public inputs validation #1195

Closed
wants to merge 23 commits into from

Conversation

IAvecilla
Copy link
Collaborator

@IAvecilla IAvecilla commented Oct 7, 2024

Caution

Content of thi PR is OK but we had to make another branch.
the new PR is this one

Update the public input validation example to support both SP1 and Risc0 implementations. Additionally, improve the steps and documentation to make it easier to follow and execute.

How to test

You can test it locally following the commands in examples/validating-public-input/README.md or use holesky following the official documentation in docs/guides/3_validating_public_input.md.

@IAvecilla IAvecilla linked an issue Oct 7, 2024 that may be closed by this pull request
@IAvecilla IAvecilla self-assigned this Oct 7, 2024
@uri-99 uri-99 changed the base branch from testnet to staging October 9, 2024 00:06
@uri-99 uri-99 force-pushed the 1132-add-public-input-example branch from d8c1b3b to 334468f Compare October 9, 2024 00:35
@uri-99 uri-99 changed the base branch from staging to testnet October 9, 2024 00:36
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should this PR be pointed at testnet?

docs/3_guides/3_validating_public_input.md Outdated Show resolved Hide resolved
docs/3_guides/3_validating_public_input.md Outdated Show resolved Hide resolved
docs/3_guides/3_validating_public_input.md Outdated Show resolved Hide resolved
examples/validating-public-input/Makefile Outdated Show resolved Hide resolved
examples/validating-public-input/Makefile Outdated Show resolved Hide resolved
examples/validating-public-input/README.md Outdated Show resolved Hide resolved
examples/validating-public-input/README.md Outdated Show resolved Hide resolved
examples/validating-public-input/README.md Show resolved Hide resolved
@uri-99 uri-99 changed the title docs: enhance example for public inputs validation refactor(example): enhance example for public inputs validation Oct 9, 2024
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single proofs emitted will not get included in a batch, so in devnet it is necesarry to send more proofs in parallel. We should add this detail in the docs since this PR is going to testnet.
After this it is an approve

@IAvecilla IAvecilla requested a review from uri-99 October 9, 2024 19:04
@uri-99
Copy link
Contributor

uri-99 commented Oct 14, 2024

Closing this PR because it is being solved in this other rebased PR

@uri-99 uri-99 closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add examples
5 participants