-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(example): enhance example for public inputs validation #1195
Conversation
d8c1b3b
to
334468f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, should this PR be pointed at testnet
?
examples/validating-public-input/contracts/validate_batch_inclusion.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single proofs emitted will not get included in a batch, so in devnet it is necesarry to send more proofs in parallel. We should add this detail in the docs since this PR is going to testnet.
After this it is an approve
Co-authored-by: IAvecilla <[email protected]> Co-authored-by: MauroFab <[email protected]>
Closing this PR because it is being solved in this other rebased PR |
Caution
Content of thi PR is OK but we had to make another branch.
the new PR is this one
Update the public input validation example to support both
SP1
andRisc0
implementations. Additionally, improve the steps and documentation to make it easier to follow and execute.How to test
You can test it locally following the commands in
examples/validating-public-input/README.md
or use holesky following the official documentation indocs/guides/3_validating_public_input.md
.