-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(example): enhance example for public inputs validation 2 #1245
refactor(example): enhance example for public inputs validation 2 #1245
Conversation
After deleting the file |
@JulianVentura It should be already fixed, the |
examples/validating-public-input/sp1/fibonacci/program/Cargo.toml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK. Haven't tested it tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to finish the review later
c79adde
to
6bb9fb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor comments, everything worked fine.
) Co-authored-by: IAvecilla <[email protected]> Co-authored-by: Mario Rugiero <[email protected]>
Note
This PR comes from a rebase of the original branch solving this issue
Original PR is this one
This branch will be merged and not the other one, to avoid git history conflicts
Update the public input validation example to support both
SP1
andRisc0
implementations. Additionally, improve the steps and documentation to make it easier to follow and execute.How to test
You can test it locally following the commands in
examples/validating-public-input/README.md
or use holesky following the official documentation indocs/guides/3_validating_public_input.md
.