Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(example): enhance example for public inputs validation 2 #1245

Merged
merged 28 commits into from
Nov 5, 2024

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Oct 14, 2024

Note

This PR comes from a rebase of the original branch solving this issue
Original PR is this one
This branch will be merged and not the other one, to avoid git history conflicts

Update the public input validation example to support both SP1 and Risc0 implementations. Additionally, improve the steps and documentation to make it easier to follow and execute.

How to test

You can test it locally following the commands in examples/validating-public-input/README.md or use holesky following the official documentation in docs/guides/3_validating_public_input.md.

@uri-99 uri-99 changed the title fix: Removing staging from validating pub inputs refactor(example): enhance example for public inputs validation 2 Oct 14, 2024
@uri-99 uri-99 marked this pull request as ready for review October 14, 2024 20:22
@JulianVentura
Copy link
Collaborator

After deleting the file sp1_fibonacci.elf if I run the command make generate_sp1_fibonacci_proof the execution fails because it's missing that file. Same happens if I execute cargo build on sp1/fibonacci/script directory. Seems the build.rs is not being executed for some reason.

@IAvecilla
Copy link
Collaborator

@JulianVentura It should be already fixed, the build.rs should run everytime now without the need of cleaning or building all the dependencies again.

Copy link
Collaborator

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Haven't tested it tho.

Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to finish the review later

batcher/aligned-sdk/src/core/types.rs Outdated Show resolved Hide resolved
docs/3_guides/3_validating_public_input.md Outdated Show resolved Hide resolved
docs/3_guides/3_validating_public_input.md Outdated Show resolved Hide resolved
@uri-99 uri-99 requested a review from JuArce October 22, 2024 17:37
@MarcosNicolau MarcosNicolau force-pushed the removing-staging-from-validating-pub-inputs branch from c79adde to 6bb9fb5 Compare October 24, 2024 16:45
@yetanotherco yetanotherco deleted a comment from github-actions bot Oct 24, 2024
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comments, everything worked fine.

examples/validating-public-input/README.md Outdated Show resolved Hide resolved
examples/validating-public-input/Makefile Outdated Show resolved Hide resolved
examples/validating-public-input/README.md Outdated Show resolved Hide resolved
@MauroToscano MauroToscano merged commit 8f3c68d into testnet Nov 5, 2024
4 of 5 checks passed
@MauroToscano MauroToscano deleted the removing-staging-from-validating-pub-inputs branch November 5, 2024 17:53
PatStiles pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants