Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_sample: fix sample data registry for 7 datasets #3334

Closed

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jun 3, 2021

PR Summary

This is complementary with yt-project/website#103 and should fix load_sample for 6 more datasets that were not following the dominant naming conventions in tarballs

this will also need to be followed by a systematic cleanup akin to #3317

@cphyc
Copy link
Member

cphyc commented Jun 7, 2021

Why are the hashes changing?

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Jun 7, 2021

Because the original tarballs didn't follow the de facto rule implemented for every other data sample: files need to unfold to a directory with the same name as the tarball (minus the .tar.gz extension), which also matches the "key" that's passed to load_sample

@neutrinoceros neutrinoceros changed the title load_sample: update (fix) sample data registry for 6 datasets load_sample: fix sample data registry for 7 datasets Jun 9, 2021
@neutrinoceros
Copy link
Member Author

this will very likely be superseded by #3366
Switching to draft for now, but I except this will end up being closed rather than merged.

@neutrinoceros neutrinoceros marked this pull request as draft June 19, 2021 11:16
@matthewturk
Copy link
Member

@neutrinoceros should this be closed?

@neutrinoceros
Copy link
Member Author

Probably, but I'd like to keep it around for now if you don't mind.

@neutrinoceros
Copy link
Member Author

closing this to clear the backlog as much as possible.
#3366 is the only change we need, and the one performed here can be done without a PR when #3366 is completed

@neutrinoceros neutrinoceros deleted the update_sample_datasets branch December 5, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants