Add TEST_TIMING alert tag #6015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thc202
reviewed
Dec 17, 2024
.../ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionScanRule.java
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
kingthorin
force-pushed
the
timing-tag
branch
2 times, most recently
from
e0f4158 to
58f25e1
Compare
Member
Author
|
Updated to be correct per rule, and correct per alert. |
Member
Author
|
Bump |
1 similar comment
Member
Author
|
Bump |
kingthorin
force-pushed
the
timing-tag
branch
from
58f25e1 to
81a36b4
Compare
Member
Author
|
Deconflicted |
Member
Author
|
Rebased current. Clarified response to previous comment. |
thc202
reviewed
Apr 25, 2025
.../ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionScanRule.java
Outdated
Show resolved
Hide resolved
.../ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionScanRule.java
Outdated
Show resolved
Hide resolved
...scanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionSqLiteScanRule.java
Outdated
Show resolved
Hide resolved
...scanrulesBeta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/ShellShockScanRule.java
Outdated
Show resolved
Hide resolved
addOns/sqliplugin/src/test/java/org/zaproxy/zap/extension/sqliplugin/ActiveScannerTest.java
Outdated
Show resolved
Hide resolved
Member
|
I didn't check yet if all rules/tests are being appropriately tagged, I will wait for the rebase to double check that (some timing tests were extracted at some point into its own rules). |
Member
Author
|
Hmm apparently I'm conflicting again. I'll get on that. |
kingthorin
force-pushed
the
timing-tag
branch
2 times, most recently
from
bccdd84 to
1f04f75
Compare
Member
Author
|
Oops forgot to update tag counts in tests after rebasing. Will do that tomorrow. |
kingthorin
force-pushed
the
timing-tag
branch
4 times, most recently
from
cf7946f to
f989d0b
Compare
Member
Author
MongoDB is the only one split out currently as far as I can see. |
Member
Author
|
Deconflicted again, and rebased current. |
kingthorin
force-pushed
the
timing-tag
branch
3 times, most recently
from
9e58d67 to
6c89e6c
Compare
Update: CHANGELOGs, scan rules, unittests. Signed-off-by: kingthorin <[email protected]>
thc202
approved these changes
Jun 27, 2025
Member
|
Thank you! |
This was referenced Jul 1, 2025
psiinon
approved these changes
Jul 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update: CHANGELOGs, scan rules, unittests.
Related Issues
N/A
Checklist
./gradlew spotlessApplyfor code formatting