Skip to content

use more recent version of halo2wrong #133

use more recent version of halo2wrong

use more recent version of halo2wrong #133

Triggered via push December 21, 2023 09:13
Status Failure
Total duration 50s
Artifacts
check_and_test
41s
check_and_test
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 25 warnings
`#![feature]` may not be used on the stable release channel: /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs#L1
error[E0554]: `#![feature]` may not be used on the stable release channel --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:1:12 | 1 | #![feature(asm)] | ^^^
`#![feature]` may not be used on the stable release channel: /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs#L2
error[E0554]: `#![feature]` may not be used on the stable release channel --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:2:1 | 2 | #![feature(asm_const)] | ^^^^^^^^^^^^^^^^^^^^^^
`#![feature]` may not be used on the stable release channel: /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs#L1
error[E0554]: `#![feature]` may not be used on the stable release channel --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:1:1 | 1 | #![feature(asm)] | ^^^^^^^^^^^^^^^^
`#![feature]` may not be used on the stable release channel: /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs#L1
error[E0554]: `#![feature]` may not be used on the stable release channel --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:1:12 | 1 | #![feature(asm)] | ^^^
`#![feature]` may not be used on the stable release channel: /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs#L2
error[E0554]: `#![feature]` may not be used on the stable release channel --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:2:1 | 2 | #![feature(asm_const)] | ^^^^^^^^^^^^^^^^^^^^^^
`#![feature]` may not be used on the stable release channel: /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs#L1
error[E0554]: `#![feature]` may not be used on the stable release channel --> /home/runner/.cargo/git/checkouts/halo2curves-8faaa2253bde9eba/f75ed26/src/lib.rs:1:1 | 1 | #![feature(asm)] | ^^^^^^^^^^^^^^^^
check_and_test
Clippy had exited with the 101 exit code
this expression creates a reference which is immediately dereferenced by the compiler: ff-uint_derive/src/lib.rs#L627
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ff-uint_derive/src/lib.rs:627:37 | 627 | let montgomery_impl = mont_impl(&cratename, limbs); | ^^^^^^^^^^ help: change this to: `cratename` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ff-uint_derive/src/lib.rs#L626
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ff-uint_derive/src/lib.rs:626:34 | 626 | let multiply_impl = mul_impl(&cratename, quote! {self}, quote! {other}, limbs); | ^^^^^^^^^^ help: change this to: `cratename` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ff-uint_derive/src/lib.rs#L625
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ff-uint_derive/src/lib.rs:625:34 | 625 | let squaring_impl = sqr_impl(&cratename, quote! {self}, limbs); | ^^^^^^^^^^ help: change this to: `cratename` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
redundant closure: ff-uint_derive/src/lib.rs#L614
warning: redundant closure --> ff-uint_derive/src/lib.rs:614:34 | 614 | (0..(limbs * 2)).map(|i| get_temp(i)), | ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
redundant closure: ff-uint_derive/src/lib.rs#L567
warning: redundant closure --> ff-uint_derive/src/lib.rs:567:34 | 567 | (0..(limbs * 2)).map(|i| get_temp(i)), | ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
manual implementation of an assign operation: ff-uint_derive/src/lib.rs#L244
warning: manual implementation of an assign operation --> ff-uint_derive/src/lib.rs:244:9 | 244 | t = t >> 1; | ^^^^^^^^^^ help: replace it with: `t >>= 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: ff-uint_derive/src/lib.rs#L178
warning: manual implementation of an assign operation --> ff-uint_derive/src/lib.rs:178:9 | 178 | v = v >> 1; | ^^^^^^^^^^ help: replace it with: `v >>= 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: ff-uint_derive/src/lib.rs#L156
warning: manual implementation of an assign operation --> ff-uint_derive/src/lib.rs:156:9 | 156 | v = v >> 64; | ^^^^^^^^^^^ help: replace it with: `v >>= 64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
unneeded `return` statement: ff-uint_derive/src/lib.rs#L141
warning: unneeded `return` statement --> ff-uint_derive/src/lib.rs:141:15 | 141 | }) => return s.value(), | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 141 | }) => s.value(), | ~~~~~~~~~
manual implementation of an assign operation: ff-uint_derive/src/lib.rs#L87
warning: manual implementation of an assign operation --> ff-uint_derive/src/lib.rs:87:13 | 87 | cur = cur << 64; | ^^^^^^^^^^^^^^^ help: replace it with: `cur <<= 64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `#[warn(clippy::assign_op_pattern)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: ff-uint_derive/src/lib.rs#L627
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ff-uint_derive/src/lib.rs:627:37 | 627 | let montgomery_impl = mont_impl(&cratename, limbs); | ^^^^^^^^^^ help: change this to: `cratename` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ff-uint_derive/src/lib.rs#L626
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ff-uint_derive/src/lib.rs:626:34 | 626 | let multiply_impl = mul_impl(&cratename, quote! {self}, quote! {other}, limbs); | ^^^^^^^^^^ help: change this to: `cratename` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ff-uint_derive/src/lib.rs#L625
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ff-uint_derive/src/lib.rs:625:34 | 625 | let squaring_impl = sqr_impl(&cratename, quote! {self}, limbs); | ^^^^^^^^^^ help: change this to: `cratename` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
redundant closure: ff-uint_derive/src/lib.rs#L614
warning: redundant closure --> ff-uint_derive/src/lib.rs:614:34 | 614 | (0..(limbs * 2)).map(|i| get_temp(i)), | ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
redundant closure: ff-uint_derive/src/lib.rs#L567
warning: redundant closure --> ff-uint_derive/src/lib.rs:567:34 | 567 | (0..(limbs * 2)).map(|i| get_temp(i)), | ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `get_temp` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
manual implementation of an assign operation: ff-uint_derive/src/lib.rs#L244
warning: manual implementation of an assign operation --> ff-uint_derive/src/lib.rs:244:9 | 244 | t = t >> 1; | ^^^^^^^^^^ help: replace it with: `t >>= 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: ff-uint_derive/src/lib.rs#L178
warning: manual implementation of an assign operation --> ff-uint_derive/src/lib.rs:178:9 | 178 | v = v >> 1; | ^^^^^^^^^^ help: replace it with: `v >>= 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: ff-uint_derive/src/lib.rs#L156
warning: manual implementation of an assign operation --> ff-uint_derive/src/lib.rs:156:9 | 156 | v = v >> 64; | ^^^^^^^^^^^ help: replace it with: `v >>= 64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
unneeded `return` statement: ff-uint_derive/src/lib.rs#L141
warning: unneeded `return` statement --> ff-uint_derive/src/lib.rs:141:15 | 141 | }) => return s.value(), | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 141 | }) => s.value(), | ~~~~~~~~~
manual implementation of an assign operation: ff-uint_derive/src/lib.rs#L87
warning: manual implementation of an assign operation --> ff-uint_derive/src/lib.rs:87:13 | 87 | cur = cur << 64; | ^^^^^^^^^^^^^^^ help: replace it with: `cur <<= 64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `#[warn(clippy::assign_op_pattern)]` on by default
check_and_test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/